In the user/%user/notifications/subscriptions page depending on where the string for the Send Method and Send Interval are being generated from the string will either be translated or not. This is due too the string coming back from the database not being translated.

The attached patch is adding the t() function around the variables incase there are other edge cases that are still not being caught.

CommentFileSizeAuthor
#1 notifications-583492.patch1.43 KBdarren.ferguson

Comments

darren.ferguson’s picture

darren.ferguson commented
StatusFileSize
new notifications-583492.patch1.43 KB

Attached is the patch with pertinent issue number

jose reyero’s picture

jose reyero commented
Status: Needs review » Needs work

Though I agree this is the quick solution, t() function is not the best option for user defined strings.

For variables, i18n module can help, thought it may add some clutter, this is the preferred solution atm.

darren.ferguson’s picture

darren.ferguson commented

Jose, will the i18n module catch the database strings that are inside the database and retrieved from the table?
I have not played too much with it so not 100% sure if that is the case in this one.

Please advise.

jose reyero’s picture

jose reyero commented

Please see #606862: node type information to be translatable about the new i18nstrings wrapper for notifications.

About send intervals we could use something like:

notifications_tt("notifications:send_interval:$send_interval:name", $name);