Since Coder does not go through JS files, we need to manually go through the JS. As the 2.x branch as started, there is no need to make any significant changes, just go through structure, spacing, styles, and standards. Also, any use of eval() needs to be eliminated (and tested :).

Comments

tmcw’s picture

tmcw commented

Commit #271248 addresses many of these issues, but to get to a level where JSLint etc., will like the files, serious work will have to be done to change the way that variables are declared in scope.

zzolo’s picture

zzolo commented
Status: Active » Fixed

@tmcw, Thanks for the JSLint stuff. I don't think it's really in the scope of 1.x to run it all through JSLint, but I think this is a great goal to have for 2.x. I am starting a new ticket.

http://drupal.org/cvs?commit=271402
I just did all the basic syntax and whitespace fixes. As much as having eval() in there sucks, I think it's better to just leave it alone for now and focus on making 2.x even better.

No real need to port, as we will need to go through the JS code of 2.x with JSLint anyway.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.