Closed (duplicate)
Project:
Drupal core
Version:
8.2.x-dev
Component:
dblog.module
Priority:
Normal
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
21 Sep 2009 at 15:57 UTC
Updated:
13 May 2016 at 17:43 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
nancydruadded tags
Comment #3
nancydruSure wish Tortoise would create proper patches...
Comment #4
arhak commentedmy usability opinion would be:
1- a whole (dangerous) fieldset to hold a single button?
2- users allowed to access reports are also allowed to get ride of them?
R/1) provide two buttons, "Clear old messages" and "Clear ALL messages"
the first one, would be configurable for how long would be the "old" window frame, and that configuration might show up as part of the description, kind of
"Clear old message will permanently remove ... beyond the %time_window" making '%time_window' evaluate to "last half hour" / "3 hours and 15 minutes" / etc (I can provide the "format_minutes" function for this kind of messages)
R/2) before rendering/submitting the form check for user_access on 'administer site configuration' as well
meaning that for log clearance users will need both, to be able to "access" and also to "administer" log history
Comment #5
nancydru1. I didn't add the field set, it's already in core. But I tend to agree that it is poorly implemented. I much prefer how we do it in Util.
2. That's how it's coded in core already. I'm not crazy about this either because I have a site where sub-admins occasionally look at the log, but they never had the capability to delete messages before.
R/1. "Clear filtered" not "Clear old" - let a time filter take care of that.
R/2. That would take care of my use case, I think. I would still rather see a "clear log" permission to be more proactive.
Comment #6
arhak commented@#5
a) yes, I know, and I agree it shouldn't be there by default, maybe enabling it at
admin/config/development/loggingb) when I want to be fast, I just want to get the last 10 top logs, or the last 1 hour logs, that is the job for a straightforward link, not a filter and then a clear button
c) nevertheless, a "Clear filtered" button would be very desirable
I was just saying that the core's fieldset is some... misplaced
it is also dangerous
and the most important, accessing the logs is not permission enough to be able to drop them
Comment #7
cburschka+1
Also, when logs *are* cleared, a log entry should be generated that notes this action.
Comment #8
MichaelCole commentedLooks like this will be D8, unless someone can bump it into D7.
Based on that and commends in #6 and #7, marking needs work...
Comment #9
MichaelCole commented#3: dblog_clear.patch queued for re-testing.
Comment #11
Bojhan commentedNo screenshot to review
Comment #13
dagmarRe-rolled.
Comment #14
mikeoharaI am testing this ticket as part of the mentored sprint at Drupal Con 2016 New Orleans.
Comment #15
mikeoharaI tested the patch applied from #13 and was able to visually confirm the result.
I would like to comment that I think that there should be more visual separation between the text and the button in 8.2.x using the default admin theme. I could make an appropriate ticket in the Seven issue queue if such a thing exists.
Comment #16
mikeoharaI have tested this out and it appears to do what it is supposed to do, and have confirmed the result with the screenshot above.
Comment #17
dagmarThanks @mikeohara. This will probably replaced with this patch that also needs a review if you want to check #2506449: Transform "Clear log messages" submit button into a link in admin/reports/dblog
Comment #18
mikeoharaUpon further review I discussed with @joelpittet providing emphases around the word "All". It seems like we do not use emphasis the same way anywhere else. It seems as though the convention is to use an
<em>...</em>tag to show emphasis which is also more language agnostic. I have created a new patch as a result, it is attached as well as a screenshot of the new result.Comment #19
mikeohara@dagmar Ah, I didn't see this comment before I committed. I will take a look, thanks!
Comment #20
mikeoharaThis is a duplicate of #2506449: Transform "Clear log messages" submit button into a link in admin/reports/dblog. Thanks to @dagmar for relating the two issues.