- '#description' => t('This will permanently remove the log messages from the database.'),
+ '#description' => t('This will permanently remove ALL log messages from the database, regardless of the current filter.'),

Comments

nancydru’s picture

added tags

Status: Needs review » Needs work

The last submitted patch failed testing.

nancydru’s picture

Status: Needs work » Needs review
StatusFileSize
new760 bytes

Sure wish Tortoise would create proper patches...

arhak’s picture

my usability opinion would be:

1- a whole (dangerous) fieldset to hold a single button?
2- users allowed to access reports are also allowed to get ride of them?

R/1) provide two buttons, "Clear old messages" and "Clear ALL messages"
the first one, would be configurable for how long would be the "old" window frame, and that configuration might show up as part of the description, kind of
"Clear old message will permanently remove ... beyond the %time_window" making '%time_window' evaluate to "last half hour" / "3 hours and 15 minutes" / etc (I can provide the "format_minutes" function for this kind of messages)

R/2) before rendering/submitting the form check for user_access on 'administer site configuration' as well
meaning that for log clearance users will need both, to be able to "access" and also to "administer" log history

nancydru’s picture

1. I didn't add the field set, it's already in core. But I tend to agree that it is poorly implemented. I much prefer how we do it in Util.

2. That's how it's coded in core already. I'm not crazy about this either because I have a site where sub-admins occasionally look at the log, but they never had the capability to delete messages before.

R/1. "Clear filtered" not "Clear old" - let a time filter take care of that.

R/2. That would take care of my use case, I think. I would still rather see a "clear log" permission to be more proactive.

arhak’s picture

@#5

a) yes, I know, and I agree it shouldn't be there by default, maybe enabling it at admin/config/development/logging

b) when I want to be fast, I just want to get the last 10 top logs, or the last 1 hour logs, that is the job for a straightforward link, not a filter and then a clear button

c) nevertheless, a "Clear filtered" button would be very desirable

I was just saying that the core's fieldset is some... misplaced
it is also dangerous
and the most important, accessing the logs is not permission enough to be able to drop them

cburschka’s picture

and the most important, accessing the logs is not permission enough to be able to drop them

+1

Also, when logs *are* cleared, a log entry should be generated that notes this action.

MichaelCole’s picture

Status: Needs review » Needs work

Looks like this will be D8, unless someone can bump it into D7.

Based on that and commends in #6 and #7, marking needs work...

MichaelCole’s picture

Status: Needs work » Needs review
Issue tags: -Needs usability review, -D7UX usability

#3: dblog_clear.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Needs usability review, +D7UX usability

The last submitted patch, dblog_clear.patch, failed testing.

Bojhan’s picture

Version: 7.x-dev » 8.x-dev
Issue tags: -Needs usability review, -D7UX usability +Usability

No screenshot to review

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dagmar’s picture

Version: 8.1.x-dev » 8.2.x-dev
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: +String change in 8.2.0
StatusFileSize
new46.39 KB
new783 bytes

Re-rolled.

mikeohara’s picture

I am testing this ticket as part of the mentored sprint at Drupal Con 2016 New Orleans.

mikeohara’s picture

Issue summary: View changes
StatusFileSize
new41.39 KB

I tested the patch applied from #13 and was able to visually confirm the result.

Test Result

I would like to comment that I think that there should be more visual separation between the text and the button in 8.2.x using the default admin theme. I could make an appropriate ticket in the Seven issue queue if such a thing exists.

mikeohara’s picture

Status: Needs review » Reviewed & tested by the community

I have tested this out and it appears to do what it is supposed to do, and have confirmed the result with the screenshot above.

dagmar’s picture

Thanks @mikeohara. This will probably replaced with this patch that also needs a review if you want to check #2506449: Transform "Clear log messages" submit button into a link in admin/reports/dblog

mikeohara’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new792 bytes
new37.99 KB

Upon further review I discussed with @joelpittet providing emphases around the word "All". It seems like we do not use emphasis the same way anywhere else. It seems as though the convention is to use an <em>...</em> tag to show emphasis which is also more language agnostic. I have created a new patch as a result, it is attached as well as a screenshot of the new result.

New Result

mikeohara’s picture

@dagmar Ah, I didn't see this comment before I committed. I will take a look, thanks!

mikeohara’s picture

Status: Needs review » Closed (duplicate)

This is a duplicate of #2506449: Transform "Clear log messages" submit button into a link in admin/reports/dblog. Thanks to @dagmar for relating the two issues.

The last submitted patch, 13: clear-log-message-clarification-583632-13.patch, failed testing.