Posted by tim.plunkett on September 21, 2009 at 9:48pm
3 followers
| Project: | Station |
| Version: | 6.x-2.x-dev |
| Component: | Schedule |
| Category: | feature request |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
Since #120296: Add start and end times to schedule grid has been rather neglected as of late, I have been resorting to manually adjusting the height of the hours on the schedule to compensate.
Perhaps this could be incorporated as a setting? See patch for the manual hack (changed from 60px to 2.5em).
| Attachment | Size |
|---|---|
| station_schedule_height.patch | 2.08 KB |
Comments
#1
Now that the schedule start and end can be set per schedule, I think the height of the schedule should be either configurable globally or per-schedule.
Anyone find this worth doing? I can work on a patch...
#2
I'd actually like this - would allow you to decrease some of the empty spaces there are in the grid.
#3
Something like this?
The strings need some work.
#4
Er, I guess $default should be uniformly arbitrarily set.
#5
I'll patch my dev install later this week and give it some go time and report back.
#6
Patched it on my dev - works great in my toying with it. I'm going to patch my live install and see if I can get any bugs out of it.
#7
#8
So the functionality works great, but I didn't put any time into the UI. I think the descriptions could be more, well, descriptive. Any ideas?
#9
UI is decently clear to me - I do like the way you can set it to wrap around a day (for instance, right now I have it starting at 6am and going until 2am the next day).
Perhaps just some different wording describing that the start and end time are display controls only and won't prevent DJs from scheduling something during that time. The next logical step might be to pop up a warning when saving a program scheduled at a time that won't be displayed? That's more a feature request though.
#10
refreshingapathy, I think you're describing #120296: Add start and end times to schedule grid. This patch is site wide, and just changes the size of each hour on the schedule. Currently it's hardcoded to 60px, this patch just makes that configurable.
#11
Ah yes, I am mixing up my patches. Give me a few minutes to make sure I've got the right things deployed and I'll edit comments appropriately.
#12
Lets try this again.
So I've got the patch from #4 installed - I tweaked it all the way down to 25 and all the way up to 75 and had no problems with theming or anything breaking.
As far as UI goes, I'd say probably a free-form box that allows values down to 25px is probably about right. Location might be admin/settings/station/ under the schedule tab?
I'd suggest wording be somewhere along the lines of "Height of one hour on the schedule." You may also want to put in a max suggested value.
#13
The only problem with that is allowing 'em's, which is why I wrote the patch in the first place. I think we're using 3em.
I like the wording you suggested, I'm just not sure how to best accommodate both px and em.
#14
Drop down for pt, in, cm, px?
#15
Oh, looking at the patch i see there's a drop down with em, px.
It looks like:
+ variable_del('station_schedule_height_value');
+ variable_del('station_schedule_height_units');
is in the wrong place if the patch's function names are to be believed. They should be in station_schedule_uninstall().
#16
The drop down is fine for me. Personally I don't see the use for having more than px and em as choices, but that's just me.
PS, typo on that page - This you select the schedule that will be used as the default for backwards compatibility.
Should probably be This LETS you select the schedule that will be used as the default for backwards compatibility.
< /nitpick >
#17
I tested this patch here and it works for me. Thanks!