My project requires migrating role duration and expiration information into the Role Expire tables. I am working on implementing the migrate module hooks to support this and will post the patch here when ready.

Thanks.

CommentFileSizeAuthor
#8 role_expire_migrate2.patch1.75 KBmikeryan
#1 role_expire_migrate.patch8.1 KBmikeryan
#1 role_expire.migrate.inc_.txt629 bytesmikeryan

Comments

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Active » Needs review
StatusFileSize
new role_expire.migrate.inc_.txt629 bytes
new role_expire_migrate.patch8.1 KB

This patch supports migrating duration information for roles - note that there's a new file, attached separately.

Thanks.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs review » Needs work

1) Patch doesn't include migrate.inc
2) I think that if an import/ export is required it should be in integrated with the features module.

stewsnooze’s picture

stewsnooze
he / him
commented

I could see how features would be a good replacement for this if it was to do with importing/exporting from different drupal sites, but how about when importing/exporting from other content management systems. I think the jobs that migrate and tw do are great fpr bringing in external data.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs work » Needs review

The .inc file is attached separately - is there a way to make a cvs diff include a new file? -N didn't seem to do it...

I'm not clear on what you mean about the features module - how does that relate to integrating with migrate?

Thanks.

stewsnooze’s picture

stewsnooze
he / him
commented
Status: Needs review » Needs work

Mike, I saw this link about adding files with cvs diff

http://wimleers.com/blog/cvs-diff-new-files-fakeadd

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

sorry, I missed the point that migrate is a module, and I thought it's kind of own implementation of the idea.

stewsnooze’s picture

stewsnooze
he / him
commented

I'll review this today then. Thanks for posting Mike.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs work » Needs review
StatusFileSize
new role_expire_migrate2.patch1.75 KB

Here's a proper patch, thanks to fakeadd...

Thanks!

stewsnooze’s picture

stewsnooze
he / him
commented
Status: Needs review » Fixed

Committed to CVS HEAD. We should get #584492 and #584046 in before we release a new version. Mike, would you like commit access to this project? You are adding some great stuff and contributing well to it.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented

Yes I would - thanks!

stewsnooze’s picture

stewsnooze
he / him
commented

I approve adding you to CVS for this project.

stewsnooze’s picture

stewsnooze
he / him
commented

@bdziewierz how about adding MikeRyan to have CVS access to this project?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.