On http://api.drupal.org/api/function/field_info_fieldable_types/7 it mentions hook_fieldable_info as the source of information to be returned. According to _field_info_collate_types() (http://api.drupal.org/api/function/_field_info_collate_types/7) this is no longer the case and this information is gathered from hook_entity_info.

CommentFileSizeAuthor
#7 584296reroll.patch14.49 KBjhodgdon
#2 584296.patch19.57 KBjhodgdon

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Title: Documentation problem with field_info_fieldable_types » field_info_fieldable_types() doc mentions nonexistent hook_fieldable_info()

Good catch! Just needs a patch...

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Title: field_info_fieldable_types() doc mentions nonexistent hook_fieldable_info() » Field info doc has multiple problems
Status: Active » Needs review
StatusFileSize
new 584296.patch19.57 KB

Hmmm...

There's a lot more than just this problem in the doc in this file. I also noticed that the doc for hook_entity_info() was formatted badly. Here's a patch to fix up all the doc in modules/field/field.info.inc, as well as the hook_entity_info() doc.

Status: Needs review » Needs work

The last submitted patch failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

This patch should probably wait until after the next code freeze milestone for a reroll, because applying it (once rerolled) would presumably cause many other patches to need a reroll.

yched’s picture

yched commented

The convention in core is not to use 3rd person in function summaries.
Those changes are no good:

- * Clear the field info cache without clearing the field data cache.
+ * Clears the field info cache without clearing the field data cache.
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

RE #5 - the convention is to use 3rd person, actually. It's just not very well followed.
http://drupal.org/node/1354

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 584296reroll.patch14.49 KB

Here's a patch reroll.

yched’s picture

yched commented
Status: Needs review » Reviewed & tested by the community

Great cleanup. Thanks !

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.