Thank you for this wonderful module! It would be great if there will be an option where you can load the parameters changed in the pjirc folder in file HeavyApplet.html or pjirc.cfg
I can set all the parameters as described on www.pjirc.com, but it takes very long time that the changes take affect. I even don't the reason when it happen.

CommentFileSizeAuthor
#5 pjirc-colors.patch7.96 KBruharen

Comments

ruharen’s picture

ruharen commented
Assigned: Breakerandi » Unassigned

Even though HeavyApplet.html and pjirc.cfg are included in Drupal PJIRC module, they are not used nor readed by the module.
One of the purposes of the module is to be able to configure Pjirc directly from Drupal without having to edit any configuration file by hand.
Also, if you are using this module, changes on those files should not affect Drupal Pjirc page. Please report it if this is happening.

I don't know what you mean with 'load parameters'. Do you want Pjirc module to load it's settings from files of a previous existing pjirc installation or anything like that?
As you can see I don't understand your issue much. Please explain it more detailed.

Last, changes in module settings are applied immediately, so the only reason I can think of about not taking efect immediately is some kind of caching: your browser cache, drupal cache, or a proxy-cache. Try it disabling all caches.

Breakerandi’s picture

Breakerandi commented

The only thing you can configure in admin/settings/pjirc is connection, applet width/height, font color/type.. thats very poor in comperison to the greater configuration opportunities as you can see here: http://www.pjirc.com/help.php?p=2
For example, to change the colours of the layout, is an veray important thing, because with this, you can make the applet fit to your personal website design.
I managed to change the background image, but, as I descirbed, the changes take affect some days later.. I added some other parameters in HeavyApplet.html, but they don't work.. How can I make them work?

Thank you for your help!

ruharen’s picture

ruharen commented
Title: Option to load parameters » Add more Pjirc options to Drupal Pjirc
Version: 6.x-1.0 » 6.x-1.x-dev
Assigned: Unassigned » ruharen

I agree with you. There is much more to configure Pjirc than what this module offers.
I'll work on it, specially about layout colours.

Expect changes soon.

As I said above, this module DOES NOT use any configuration file included with Pjirc, so your changes in HeavyApplet are completely ignored nor even noticed. There is no way you can make it work right now.
My plan is to add all configuration parameters in the module configuration, so you don't have to edit any configuration file by hand.

Breakerandi’s picture

Breakerandi commented

"My plan is to add all configuration parameters in the module configuration, so you don't have to edit any configuration file by hand."

That would great!
Is there any opportunitiy how I could help you? Perhaps easy tasks, I can do with my few PHP skillz or perhaps some money?

ruharen’s picture

ruharen commented
StatusFileSize
new pjirc-colors.patch7.96 KB

It took me more than I intended but now I have colors settings for pjirc :D

Patch attached. Please test it if you can.

ruharen’s picture

ruharen commented
Title: Add more Pjirc options to Drupal Pjirc » Add color options to Pjirc module
Status: Active » Needs review

I change title to narrow the scope of this issue.

Set this to 'need review' as patch is atached.
I probably commit this in a few days.

Breakerandi’s picture

Breakerandi commented

Thank your very much, but every time when i try to patch something goes wrong.. I think my php skillz are not good enouph for patching. So would be great if this patch will be in the next release!

cesareaugusto’s picture

cesareaugusto commented

Yep. Same in here. I'm not that into the patching thing. Would it be possible to merge the new features to the actual dev snapshot release?

ruharen’s picture

ruharen commented

Rather sure i'll do it soon.

But first, please try this: http://drupal.org/patch/apply
See the section about Windows if you use it.

ruharen’s picture

ruharen commented
Assigned: ruharen » Unassigned
Status: Needs review » Fixed

I've commited this. It will be available in the next -dev tarball (less than 24 hours).

Enjoy

cesareaugusto’s picture

cesareaugusto commented

Gread! I tested it and I works fine for me! Just a little usability notice... The "Colors" section should be within the group "pixx GUI settings" as color settings are actually Pixx Parameters.

More, I was wondering whether it would be possible to implement the other Pixx Parameters (http://www.pjirc.com/help.php?p=2) as well too to make PJIRC fully configurable through Drupal... e.g. customizing the applet background image, highlightnick, timestamp, help page, etc etc

ruharen’s picture

ruharen commented

As for now, I think I leave it as is. I agree that "Colors" is part of "pixx" but I think people do not have to know what pixx nor a GUI is, so I thought "Colors" is more intuitive. After this said, I also don't like the pixx-GUI section name and I would like to change its name to another more user friendly.

For the other question, please read my comment on #3. I will be adding more and more features over time. For example, I was thinking about how to add a configurable background image just yesterday, and I have to play and experiment with it a bit. I'm opening a new issue for discussing that, ok?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.