location module declares this constant also. Should it be renamed (to PLAYLIST_PATH)?
ha, yes. thought i had fixed this already...
fixed.
LOCATION_PATH is also defined in location.inc...
Yes, I know that, so this should already be fixed now. I changed it to PLAYLIST_PATH.
Sorry, I meant LOCATION_PATH is also defined in playlist.inc... It looks like you only committed playlist.module.
ah...whoops! i got rid of it in playlist.inc, since i don't think i needed to declare it twice.
ok! should be fixed now... (hopefully) :)
zirafa, could you roll this into the 4.6 version as well? Is it appropriate for me to reactivate as a 4.6 bug (as I am doing this moment)?
Thanks!
This should be fixed in 4.6 and 4.7. I highly recommend looking into the 4.7 version as the module has been completely rewritten.
Comments
Comment #1
zirafa commentedha, yes. thought i had fixed this already...
Comment #2
zirafa commentedfixed.
Comment #3
yongrokc commentedLOCATION_PATH is also defined in location.inc...
Comment #4
zirafa commentedYes, I know that, so this should already be fixed now. I changed it to PLAYLIST_PATH.
Comment #5
yongrokc commentedSorry, I meant LOCATION_PATH is also defined in playlist.inc...
It looks like you only committed playlist.module.
Comment #6
zirafa commentedah...whoops! i got rid of it in playlist.inc, since i don't think i needed to declare it twice.
Comment #7
zirafa commentedok! should be fixed now... (hopefully) :)
Comment #8
matt@antinomia commentedzirafa, could you roll this into the 4.6 version as well? Is it appropriate for me to reactivate as a 4.6 bug (as I am doing this moment)?
Thanks!
Comment #9
zirafa commentedThis should be fixed in 4.6 and 4.7. I highly recommend looking into the 4.7 version as the module has been completely rewritten.