The coder module reports several coding convention issues for role_expire (elseif, spacing, etc.). I'll fix these up later today...

CommentFileSizeAuthor
#4 role_expire-584492.patch17.74 KBmikeryan
#1 role_expire_coder.patch17.89 KBmikeryan

Comments

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Active » Needs review
StatusFileSize
new role_expire_coder.patch17.89 KB

Here's a patch - lots of trailing spaces, some tabs, string concatenation without spaces, etc...

stewsnooze’s picture

stewsnooze
he / him
commented

This no longer applies after #584048 went in

stewsnooze’s picture

stewsnooze
he / him
commented
Status: Needs review » Needs work
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs work » Needs review
StatusFileSize
new role_expire-584492.patch17.74 KB

Rerolled.

stewsnooze’s picture

stewsnooze
he / him
commented
Status: Needs review » Fixed

Committed to CVS HEAD

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.