The relationships that views defines for the core modules use 'field' for the base field but this doesn't match up with what views_handler_relationship defines:

 * - base: The new base table this relationship will be adding. This does not
 *   have to be a declared base table, but if there are no tables that
 *   utilize this base table, it won't be very effective.
 * - base field: The field to use in the relationship; if left out this iwll be
 *   assumed to be the primary field.

I'm guessing that since it's joining on the base table's primary field this error was masked. I noticed it after copy pasting the code into another module that used a non-primary field.

The patch also fixes some spelling errors I noticed and my editor removed some trailing whitespace.

Comments

drewish’s picture

Version: 6.x-2.x-dev » 6.x-3.x-dev
StatusFileSize
new5.99 KB

here's a patch for 3.x. no real changes besides accounting for a change in an adjacent line.

merlinofchaos’s picture

Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Needs review » Patch (to be ported)

Ok, this is commited to 6.x both 2.x and 3.x branches. Doesn't apply to the 7.x--3.x branch -- needs a port.

dawehner’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new5.94 KB

Fast port

matt2000’s picture

Status: Needs review » Reviewed & tested by the community

looks good, applies clean, doesn't break anything AFAICT.

dawehner’s picture

Arg Earl commited this patch together with another patch. I will try to commit it tomorrow

dawehner’s picture

Status: Reviewed & tested by the community » Fixed

Today it tomorrow :)
Thanks for the review!

Fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.