Closed (fixed)
Project:
Location
Version:
6.x-3.x-dev
Component:
Data update
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
22 Sep 2009 at 20:10 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
claudiu.cristeaFixed a letter and changing the status.
Comment #2
claudiu.cristeaReference: http://en.wikipedia.org/wiki/Counties_of_Romania#Current_list
Comment #3
yesct commentedadding location.xx.inc
hmm I thought there was a master issue to consolidate location.xx.inc problems... but I could not find one.
Here are all the ones with location.xx.inc in them: http://drupal.org/project/issues/search/location?order=last_comment_time...
You reviewed your own patch? :)
Comment #4
claudiu.cristeaThe ticket is from September 2009. There's nothing to review on it. It's a simple fix. Since the ticket was created I installed locations on many sites and every time I have applied the patch.
And yes... it's "critical" while is screwed up your data on your site. I really don't understand why it takes so long to commit such a obvious fix?
Comment #5
yesct commentedThanks for the explanation. That helps. I'll put this on a list of "simple obvious fixes/patches" and see if that helps get it committed. It takes so long to get things committed to location... because there is no paid work for this module. It is a mess, and the maintainer had some life issues take priority for a while. But some patches are getting in as of this March (Thanks Ankur), see http://drupal.org/project/cvs/18723. Maintaining a module is a time consuming, sometimes thankless job. And the only thing we non-maintainers can do is try and make it as easy as possible for the maintainer to commit things.
Doing a coding style review, having someone else check it on a site, providing a summary of the changes in the code, ... anything we can think of that the maintainer might have to do, that we can do will help take 30 minutes or an hour off of each commit and that will help get commits in.
Maybe you could find a similar simple patch (a data update even) in the queue, and contact a person who commented on that issue, and arrange a trade to test each other's patch. http://drupal.org/project/coder, http://drupal.org/patch/review can help with that. Thanks for hanging in there. We can turn the location issue queue around!
(and since this problem has a patch... and it is a total pain and not ideal, but you can just keep patching sites, I dont think this is critical right now.... I suggest we keep it at normal priority, until some of the larger issues (like cck location are in).
Lets leave it at RTBC.... though. A compromise. :) And I'll tag it as an easy fix to consider committing.
Comment #6
ankur commentedCommitted to HEAD, DRUPAL-6--3
Comment #7
yesct commentedremoving the tag since this was committed. :)
http://drupal.org/cvs?commit=350712
http://drupal.org/cvs?commit=350710