Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.As per the title. I think the attached patch fixes the problem.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | help.patch.txt | 1.05 KB | gopherspidey |
| help.module.empty_ul.patch | 831 bytes | markus_petrux |
Comments
Comment #1
killes@www.drop.org commentedunder which conditions do you get empty uls?
Comment #2
markus_petrux commentedThis is not so obvious here because the number of modules that you may have installed is pretty stable. But it happens.
Try adding/removing modules and visiting admin/help with Firefox's Tidy extension enabled.
I think the rule is when the number of items is divisible by 4. The code I proposed in the patch just makes sure a new UL element is added only when there are more items to show. I think it is efficient so it computes
$i+1just once (it was done twice before) and it just needs to capture the count into a valirable. There might be better ways though.Comment #3
gopherspidey commentedI do not see the affect of this patch, but I have rerolled it for the HEAD.
Comment #4
beginner commentedI cannot reproduce the bug.
you have a minimum of 7 help items (required core modules + help), so you cannot have an empty UL.
Even when the number of items is NOT divisible by 4, I do not see any problem as the page validates here http://validator.w3.org/ .
Probably, the bug has been fixed since.
Comment #5
(not verified) commented