Download & Extend

Do not restrict signup output to pages

Project:Signup
Version:6.x-1.0-rc6
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:active

Issue Summary

function signup_nodeapi, lines 777-81 of signup.module read

    case 'view':
      // If this is a signup node, figure out what (if anything) to print.
      // Only include any of this if we're trying to view the node as
      // a page, not during the view from comment validation, etc.
      if ($page && _signup_needs_output($node)) {

The first part of the condition means that signup content will only show up on pages. The reason given in the comments directly above seems to be directed at a special case, comment validation, but what is actually done makes signup information unavailable for a lot of unspecified cases. For example, why shouldn't you have a view that lists a number of signup-enabled nodes and that includes a list of signed up users for each of them? Now, you can only do this with a row style using fields, but not using nodes. What if the entire node is used as a block (as opposed to having only the signup information in a block)?

The condition that has to be met for the exclusion of output should be as specific as possible.