Markup elements should not have title or description [#58698]

Form elements of type #markup (the default type) are allowed to have a title and a description, according to http://api.drupal.org/api/HEAD/file/developer/topics/forms_api_reference.... But these attributes are not outputted by theme_markup(), because it does not have the standard call to theme('form_element').

Attached patch fixes this.

Comment	File	Size	Author
#2	theme_markup_1.patch	655 bytes	Jaza
#1	theme_markup_0.patch	582 bytes	Jaza
	theme_markup.patch	599 bytes	Jaza

Comments

Comment #1

Jaza commented 14 April 2006 at 05:51

Status	File	Size
new	theme_markup_0.patch	582 bytes

Removed #id parameter from call to theme('form_element'), as this doesn't apply for #markup.

Comment #2

Jaza commented 14 April 2006 at 06:25

Status	File	Size
new	theme_markup_1.patch	655 bytes

Updated to only call theme('form_element') if #title or #description are set, because calling it for existing #markup elements in core seems to wreck the layout of some pages (e.g. admin/modules).

Comment #3

killes@www.drop.org commented 14 April 2006 at 09:07

Status:

Reviewed & tested by the community

» Needs review

This needs a review by some form API person.

Comment #4

Jaza commented 15 April 2006 at 04:34

Title:	theme_markup() should call theme('form_element')	» Markup elements should not have title or description
Status:	Needs review	» Active

I have talked to chx, and it has been determined that markup elements should never be passed through theme('form_element'), as this wraps the element in a <div class="form-item">, which should never happen for markup.

The conclusion is that when a title and/or a description is needed, use type item instead of type markup. Title and description should no longer be allowed for elements of type markup. I couldn't see anywhere in the code that the rules of allowed attributes for form element types is defined, so it looks like it's just the docs on api.drupal.org that need to be updated.