1. After setting up a campaign, going to the campaign and filling out the form and clicking 'send', you are taken to the 'thank you' page and it appers the message was sent. However, no e-mail is being sent.

2. On the 'thank you page', clicking 'tell a friend' crashes IE6 on XP SP2.

3. When setting up a campaign, the 'personal message at top' option is not saved. (Actually, the code looks like it is not being retrieved from the settings for edit.)

4. Page listing nodes of type 'citizenspeak' empty if no campaigns are promoted to front page, or, campaigns must be promoted to front page to show on page listing 'citizenspeak' nodes? I think I see where to fix that, but is there a reason for this?

Otherwise, pretty nice module. #1 is sort of a showstopper for me, though. Is there some other module I'm supposed to have installed/activated (have the massmailer and phplist enabled). Other e-mail functions (contact user from profile, notifications, etc.) all seem to work fine.

Also, why is there a limit of 25 target e-mail addresses? Can't imagine needing more, but you never know.

Comments

rneal’s picture

rneal commented

OK, never mind. I think I have resolved all these issues with minor changes at my site (except the 25 recipients limit).

1. E-mail not sent, there was no error checking. I added error checking and display a message if the mail() function fails. My problem was multiple e-mail addresses separated by spaces. They must apparently be separated by commas on my server.

2. Changed 'tell a friend' to not translate/format/scrub the message subject and body text for the 'mailto:' link.

3. The 'personal message on top' option was being saved in the database, it just wasn't being set on the edit form. Changed it to set the checkbox based on the saved setting.

4. The 'page' hook was selecting only front page promoted campaigns. Removed the 'where' clause pertaining to promted.

Also, I changed it to make the address/city/state/zip optional (well, not required). It would be nice if this were an option that could be set when the campaign was setup.

Anyway, nice module. Looking forward to seeing if if there is any interest in using it at my site.

georgehotelling’s picture

georgehotelling commented
Priority: Critical » Minor
Jo Lee’s picture

Jo Lee commented

Glad you were able to resolve the bug isseus.

Re the 25 email addresses. We limit it to 25 to avoid any possible use of the service for spam purposes.

Thanks, Jo

georgehotelling’s picture

georgehotelling commented
Status: Active » Closed (fixed)

Please re-open this with a patch if you get a chance.