drupal_http_request() does not use drupal_generate_test_ua(), even after applying the patch... not sure if this is important, just noticed it while updating some tests

CommentFileSizeAuthor
#2 D6-core-simpletest.patch15.01 KBdave reid
#2 587988-simpletest-patch.patch5.81 KBdave reid
#1 D6-core-simpletest-rev.patch22.4 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new D6-core-simpletest-rev.patch22.4 KB

Revised patch for the patch in simpletest. Not a patch of a patch if that isn't already confusing. Also fixes some double checking of the user agent in _drupal_bootstrap(). Confirmed everything worked.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 587988-simpletest-patch.patch5.81 KB
new D6-core-simpletest.patch15.01 KB

Please also show your support for getting this patch into core with #582942: Add latest SimpleTest backport directly to core. Left some extra stuff in the last patch.

Attaching new revised, fresh D6-core-simpletest.patch and also a patch to the existing patch, which is just blowing my mind... :)

boombatower’s picture

boombatower commented
Status: Needs review » Fixed

Committed.

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.