Download & Extend
SimpleTest » Issues

drupal_http_request() does not use drupal_generate_test_ua()

Posted by John Morahan on September 25, 2009 at 3:50pm
Project:SimpleTest
Version:6.x-2.9
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

drupal_http_request() does not use drupal_generate_test_ua(), even after applying the patch... not sure if this is important, just noticed it while updating some tests

Login or register to post comments

Comments

#1

Posted by Dave Reid on September 25, 2009 at 4:12pm
Status:active» needs review

Revised patch for the patch in simpletest. Not a patch of a patch if that isn't already confusing. Also fixes some double checking of the user agent in _drupal_bootstrap(). Confirmed everything worked.

AttachmentSizeStatusTest resultOperations
D6-core-simpletest-rev.patch22.4 KBIgnored: Check issue status.NoneNone

#2

Posted by Dave Reid on September 25, 2009 at 4:19pm

Please also show your support for getting this patch into core with #582942: Add latest SimpleTest backport directly to core. Left some extra stuff in the last patch.

Attaching new revised, fresh D6-core-simpletest.patch and also a patch to the existing patch, which is just blowing my mind... :)

AttachmentSizeStatusTest resultOperations
D6-core-simpletest.patch15.01 KBIgnored: Check issue status.NoneNone
587988-simpletest-patch.patch5.81 KBIgnored: Check issue status.NoneNone

#3

Posted by boombatower on September 25, 2009 at 8:35pm
Status:needs review» fixed

Committed.

Thanks.

#4

Posted by System Message on October 9, 2009 at 8:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here