drupal_http_request() does not use drupal_generate_test_ua()

John Morahan - September 25, 2009 - 15:50
Project:SimpleTest
Version:6.x-2.9
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

drupal_http_request() does not use drupal_generate_test_ua(), even after applying the patch... not sure if this is important, just noticed it while updating some tests

#1

Dave Reid - September 25, 2009 - 16:12
Status:active» needs review

Revised patch for the patch in simpletest. Not a patch of a patch if that isn't already confusing. Also fixes some double checking of the user agent in _drupal_bootstrap(). Confirmed everything worked.

AttachmentSize
D6-core-simpletest-rev.patch 22.4 KB

#2

Dave Reid - September 25, 2009 - 16:19

Please also show your support for getting this patch into core with #582942: Add latest SimpleTest backport directly to core. Left some extra stuff in the last patch.

Attaching new revised, fresh D6-core-simpletest.patch and also a patch to the existing patch, which is just blowing my mind... :)

AttachmentSize
D6-core-simpletest.patch 15.01 KB
587988-simpletest-patch.patch 5.81 KB

#3

boombatower - September 25, 2009 - 20:35
Status:needs review» fixed

Committed.

Thanks.

#4

System Message - October 9, 2009 - 20:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.