Disabling modules fails [#588040]

Hi,
I've experienced tha same issue reported in http://drupal.org/node/449332 that is, trying to disable a module doesn't work.
I used the following syntax, as suggested by Vaish but it doesn't work.

<?xml version="1.0" encoding="ISO-8859-1"?>
<pattern>
  <info>
    <title>Simple Disable</title>
    <description>Simply disable a mode</description>
    <author>Erik LaBianca</author>
    <author_email>erik@quonic.com</author_email>
    <version>0.1</version>
    <author_date>2009-04-24</author_date>
    <category>Modules</category>
    <core>5.x</core>
  </info>
  <actions>
    <modules>
      <module delete="1">xmlsitemap_engines</module>
      <module delete="1">xmlsitemap</module>
    </modules> 
  </actions>
</pattern>

Has any of you experienced/resolved the same issue?
Thank you,
Alessandro

Comment	File	Size	Author
#8	error616.jpg	48.22 KB	colinmcclure

Comments

Comment #1

alessandroronchi commented 28 September 2009 at 08:25

Hi,
after some code investigation on patterns.module it turned out that the patterns_sync_form_values function, used to "fix some parts of the #post values based on the original form" in the patterns_execute_action function re-enables the modules which were told to be disabled/deleted via patterns.

Still investigating, this was to keep trace of any step torward a solution.

Regards, Alessandro

Comment #2

alessandroronchi commented 28 September 2009 at 12:44

Hi,
we discovered that the problem is not strictly bound to disabling modules.
We experienced the same issue by using the form tag trying to disable a form option (unchecking the corresponding checkbox).

I confirm that the patterns_sync_form_values function mentioned in the previous comment is responsible of this behaviour.

Regards, Alessandro

Comment #3

vaish commented 29 September 2009 at 16:42

Hi Alessandro,

You are right about this issue not being specific only to disabling modules. It's related to disabling checkboxes in general and caused by patterns_sync_form_values not handling disable attribute properly. You can expect fix for this issue very soon.

Vaish

Comment #4

dman commented 24 November 2009 at 02:28

bump.
I can't see a fix for this in current dev. Is it in, or should it be worked on?

I looked at patterns_sync_form_values but it's scary.

Comment #5

vaish commented 6 March 2010 at 15:37

Status:

Active

» Fixed

Fix for this issue finally got committed. It required adjusting the syntax for modules action in order to make it consistent with the syntax used in other places where multiple checkboxes are handled. This is the new syntax:

    <modules delete="1">
      <module>xmlsitemap_engines</module>
      <module>xmlsitemap</module>
    </modules>

Thanks everyone for your patience.
Vaish

Comment #6

colinmcclure commented 12 March 2010 at 12:17

I have a fresh installation of Drupal 6.16 with Patterns module as of 12 March 2010 installed however I am able to enable modules through Pattern but not disable?

<?xml version="1.0" encoding="ISO-8859-1"?>
<pattern>
  <info>
    <title>Enable Core Items</title>
    <category>Setup</category>
    <core>6.x</core>    
	<version>0.5</version>
  </info>  
<actions>
<modules enable="1">
	<module>aggregator</module>
	<module>poll</module>
</modules>

	<modules delete="1">
      <module>color</module>      
    </modules> 
 
</actions>
</pattern>