I needed the mail in the customer report at admin/store/reports/customers so I added to the logic. It's now another column available on the screen and on the CSV. I'd think having a way to export customer's email addresses is something worth having, certainly the code is not harmful.

CommentFileSizeAuthor
#15 ubercart-add_email_customer_report-588064.patch6.21 KBhles
#13 ubercart-add_email_customer_report-588064.patch12.13 KBhles
#12 ubercart-add_email_customer_report-588064.patch6.2 KBhles
#9 uc_reports-customer-report-email-588064-9.patch6.13 KBJonathan Peterson
#1 reports_customer_with_mail.patch6.26 KBhanoii
reports_customer_with_mail.patch6.26 KBhanoii

Comments

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
StatusFileSize
new reports_customer_with_mail.patch6.26 KB

It's a reversed patch, sorry, attached is the proper one.

rs6blades’s picture

rs6blades commented
Component: Code » Website
Assigned: Unassigned » rs6blades
Category: feature » bug
Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community

This is a Great Patch and extremely useful. Not sure why this was not part of the original Module to begin with. Being able to manipulate customer database into format that will help to integrate into a better Follow up Sales tool.

Thanks Hanoii for your great support and work on this. Sure saved my Butt!!

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Version: 5.x-1.8 » 5.x-1.9
Component: Website » Code
Assigned: rs6blades » Unassigned
Priority: Critical » Normal
hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Category: bug » feature

Although I also think this would be helpful to have it in the module, it's not really a bug as it doesn't cause any problem. It's just a new thing that can be added, thus, it's a feature request.

rstaylor’s picture

rstaylor commented

+1 I've needed this on several sites, it should be part of the core module. Should also be in 6x-2.x etc.

hankpalan.com’s picture

hankpalan.com commented

+1 can we get this into core soon? or at least get a 6.x patch?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: mail available in customer report » Add email to customer report
Version: 5.x-1.9 » 6.x-2.x-dev
Status: Reviewed & tested by the community » Needs work

Bumping to 6.x, where the patch will likely need revising first.

urban farmer’s picture

urban farmer commented

I know this might be a stupid question, but how do I apply this patch? I assume I copy the code somewhere. I tried pasting it into the bottom of this file, uc_reports/uc_reports.module, but it did not work.

Jonathan Peterson’s picture

Jonathan Peterson commented
Status: Needs work » Needs review
StatusFileSize
new uc_reports-customer-report-email-588064-9.patch6.13 KB

Not a stupid question! The code in question has moved since it was first written, from uc_reports.module to uc_reports.admin.inc, so applying it would be bound to fail.

The attached patch is the same code, only applied to the right place for 6.x-2.x-dev. (As of writing, it works on 6.x-2.7 also.) Setting it back to Needs Review.

Status: Needs review » Needs work

The last submitted patch, uc_reports-customer-report-email-588064-9.patch, failed testing.

tr’s picture

tr commented
Component: Code » Reports
hles’s picture

hles commented
Status: Needs work » Needs review
StatusFileSize
new ubercart-add_email_customer_report-588064.patch6.2 KB

Same as previous patch but emails are now displayed as links (mailto) instead of plain text.
Against latest dev.

hles’s picture

hles commented
StatusFileSize
new ubercart-add_email_customer_report-588064.patch12.13 KB

Disregard patch in #12. It was based on #9, which was using formatted values for prices when exporting a CSV file.
New patch with raw values in CSV attached.

Status: Needs review » Needs work

The last submitted patch, ubercart-add_email_customer_report-588064.patch, failed testing.

hles’s picture

hles commented
Status: Needs work » Needs review
StatusFileSize
new ubercart-add_email_customer_report-588064.patch6.21 KB

wow.. not my day. Again disregard #13. Not sure how awake I am right now. Sorry guys.

tr’s picture

tr commented
Status: Needs review » Closed (won't fix)

This will be unnecessary in 7.x-3.x when #568854: Replace uc_reports with Views is completed.

While it's great you've supplied a patch for others to use, I don't think this is something that's going to get into 6.x-2.x at this point. When adding new functionality, we're putting our efforts into the current version of Ubercart. While we're still actively fixing bugs in 6.x-2.x, development of new features for an old version isn't the best use of our time. This particular patch may be useful to some, but is just clutter to others. It's not a general mechanism for adding additional information to reports, which is what we really need and what we get with the better Views integration in 7.x-3.x. Reports can be made using Views even in 6.x-2.x, and patches like this can be used for other site-specific needs.