Hi, I have installed iTweak on a Drupal 6.13 site. The edit node forms look great. However, the beautified file listings appear in duplicate together with the default file listing when viewing a file (so, I get the beautified file listing box, and underneath "attachments" with the default list of files). I don't have the image preview thing installed, in case that's a problem.
Thanks.

Comments

pimousse98’s picture

pimousse98 commented

Ok, this seems to be a conflict with download hit counter (download_count module). That module adds a column to the default file list that displays how many times the file has been downloaded. If I login as a user who doesn't have the rights to see this, then there is only the beautified file list.
Problem fixed on my part, but still might be worth fixing. Maybe make the beautifying of the file list optional???

iva2k’s picture

iva2k commented
Title: Duplicate listing of files » Duplicate listing of files when also using download_count.module

Thanks for the report - good to have it documented.

I will try to figure it out when I have some free time. I will expedite review if there is a patch submitted, of course.

iva2k’s picture

iva2k commented
Status: Active » Postponed (maintainer needs more info)

I looked into download_count.module code, and I consider this a problem with the way download_count.module is implemented. It does all node alteration in node_api() hook call, instead of using more standard theming hooks (like iTweak_Upload does). That creates quite difficult to resolve compatibility problem. I can think of only few ways to resolve this:
1. Rewrite download_counter module. This will still need some minimal updates to iTweak_Upload.
2. Add special provisions into iTweak_Upload code that would deal specifically with the effects of download_count module.
3. Integrate downloads counting functionality into iTweak_Upload and remove the need for download_count.module.

I think #2 and #3 options are not very favorable. #2 will require a lot of code that does not belong in iTweak_Upload, and it will be counter to the Drupal module philosophy and will break each time when download_count.module is updated. #3 is bad because iTweak_Upload mission does not include counting the number of downloads.

#1 is not straightforward either, since it is up to the download_count's maintainer. I thought about modified #1 approach, with refactoring the code into a completely new module that would replace download_count. Then it is possible to do and creates a compatibility path. However it does not land high on my priority list to maintain a new module.

Any thoughts or comments?

iva2k’s picture

iva2k commented

Update: I've done some redesign of how re-theming works in iTweak Upload, which puts problems with double attachments lists to rest. However, it removes any download stats from the display. In order to show download counts in iTweak upload I need some cooperation from download_count.module maintainers. I will post a patch to their queue.

iva2k’s picture

iva2k commented
Assigned: Unassigned » iva2k
Status: Postponed (maintainer needs more info) » Fixed

Issue fixed in iTweak Upload 6.x-2.x-dev as of Feb 20 2010. Module download_count should be patched using #720686: compatability with iTweak Upload module to actually display counts/last download in attachments list by iTweak Upload.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.