Closed (fixed)
Project:
Chaos Tool Suite (ctools)
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
25 Sep 2009 at 20:31 UTC
Updated:
31 Dec 2009 at 23:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
sdboyer commentedSimple enough and makes sense; let me have a look, and I'll likely commit.
Comment #2
merlinofchaos commentedThis does not pass a coding standards review. All if statements must contain { } to prevent errors in the future.
Comment #3
brynbellomy commentedFixed the {} braces and ran this through coder. Should be clean now.
Comment #4
merlinofchaos commentedHm. So for another purpose, I had to retool contexts such that optional contexts now provide an empty context when they do not appear. So this approach doesn't quite work right, now. And, in fact, opens it up to a much easier approach. Which I'm sorry about because now this needs to be redone.
Comment #5
brynbellomy commentedAlright, this has been fixed per your suggestions on IRC, I think. Happy to settle any other changes as well, though.
Comment #6
brynbellomy commentedWhoops, the hooks all still bore my name. Fixed.
Comment #7
brynbellomy commentedSigh. Multiple versions of this file are ruining my life.
Comment #8
merlinofchaos commentedReworked somewhat and committed.
One note of import: When using t() try to avoid using a / in the text, as it's harder on translators. So switch from using '' to "" if there is a ' in the text; only use / if you absolutely have to.