create emfield modal template file and preprocessors

I just updated and I'm getting the same error when I click on a emvideo field thumbnail. I'm not using the garland theme:

"Fatal error: Call to undefined function phptemplate_get_ie_styles() in /home/xxx/public_html/drupal/sites/all/modules/emfield/contrib/emvideo/emvideo.theme.inc on line 424"

Replace the line 424 of emfield/contrib/emvideo/emvideo.theme.inc

$ie = phptemplate_get_ie_styles();

to

$ie = ""; //phptemplate_get_ie_styles();

The problem is that this file is assuming that we are using Garland as default theme.

http://api.drupal.org/api/function/phptemplate_get_ie_styles/6

oops. got that fixed now, hadn't realized that was a garland-specific function. sorry about that...

That fixed the error, but I'm not sure if the changes in the theme is causing side effects in other modules.

After updating and doing the above fix, my bowob module (chat bar) is now loading inside the lightbox emvideo when it wasn't before. I think this might have something to do with changing to use some iframe?

Should I start my own issue for this or is it related?

accidental double post - please delete

Ok removing $closure from the new iframe in emvideo.theme.inc has solved my issue above.

Not sure the reasoning behind the new modal iframe.

emfield modals have always used iframes. however, they didn't previously contain scripts. this meant that it never worked for sites using swfobject or jw flash player with youtube. this last run did iframes up properly, complete with the header, body, and scripts. unfortunately, that means that some modules that (incorrectly, from my stand-point) load their scripts on all pages will also be loaded for modal pages now.

not sure how to do this but on a case-by-case basis. for instance, admin_menu has a hook (that this module now implements) to stop its scripts from being loaded. i prefer an opt-in rather than opt-out solution for most of these modules, as that solution means digging into the api to see how to do that. i don't feel like doing that for every bowob, chat bar, or tom-dick-or-henry module out there; the issue more likely belongs in their queues anyway.

however, as always, patches are welcome.

i will move the theme function into a template file next week, complete with preprocessors, which will make it easier to override at the theme level. i'll also take a quick look at the bowob/chat bar module to see if they provide an easy method to opt-out of their script.

Sounds good.

I was told from bowob that "The chat is shown when the hook_footer (theme) call." So I guess that must be called in an update from emvideo since this didn't occur before.

added some thoughts to #588826: Bowob multichat showing up in lightbox module for the bowob chat bar issue. the rest of this fixed.

I'm getting the same error and have tried commenting out $closure and
$ie = ""; //phptemplate_get_ie_styles(); to no avail. (just displays the video in a new window)

I've now updated to .dev and the modal doesn't load. it too refreshes to a new page with video element.

I'll try to do a cvs revert and rebuild my tables accordingly.