After upgrading to php 5.3 I started receiving this error:

warning: Parameter 2 to rules_admin_form_edit() expected to be a reference, value given in [site_path]/drupal-6.14/includes/form.inc on line 371.

To fix it I took the "&" off the &$proxy parameter on this line:

function rules_admin_form_edit(&$form_state, &$proxy, $element) {
CommentFileSizeAuthor
#6 rules-6.x-1.1-php53-1.patch635 bytesthekevinday
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

infojunkie’s picture

infojunkie
Location Vancouver
CreditAttribution: infojunkie commented
Component: User Interface » User interface

subscribe

askibinski’s picture

askibinski CreditAttribution: askibinski commented

In general, I believe it's a pretty bad idea to have a Drupal 6 site running on php 5.3 at this time. While core should work fine, many contrib modules will throw you warnings...

infojunkie’s picture

infojunkie
Location Vancouver
CreditAttribution: infojunkie commented

@askibinski that's right, and that's why we must report the warnings and failures to module maintainers because we will all eventually need to upgrade to PHP 5.3 and beyond.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Status: Active » Fixed

thanks, I fixed that warning. Please reopen if you find more problems.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

thekevinday’s picture

thekevinday CreditAttribution: thekevinday commented
Status: Closed (fixed) » Needs work
FileSize
rules-6.x-1.1-php53-1.patch635 bytes

I recently came across another rules reference warning, this time with: rules_forms_form_alter

This patch fixes the newly discovered php 5.3 reference warning.
Please check to make sure this is a safe change.

edit: I want to emphasize: Please make sure that it is safe to remove the & at this location.

thekevinday’s picture

thekevinday CreditAttribution: thekevinday commented

My patch may not be the correct fix, see my post here:
http://drupal.org/node/360605#comment-2340170

You may want to double check the original fix as well.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Status: Needs work » Fixed

Thanks for spotting this. I think removing the reference was fine for the previous one, but in this case it's probably not. But I suppose hook_form_alter() is only called by core? So in that case it need to be fixed there.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

spacereactor’s picture

spacereactor CreditAttribution: spacereactor commented
Status: Closed (fixed) » Active

when i delete a rule from rule set, i got this error
warning: call_user_func_array() expects parameter 2 to be array, string given in /home/mysite/public_html/sites/all/modules/rules/rules/rules.module on line 851.

mitchell’s picture

mitchell CreditAttribution: mitchell commented
Status: Active » Closed (fixed)

@spacereactor: Please create a new issue. This helps us stay organized and work with the many issues people post.

Renee S’s picture

Renee S CreditAttribution: Renee S commented

@spacereactor Issue and patch here: #878124: PHP5.3 warning: call_user_func_array() expects parameter 2 to be array