error editing condition after php 5.3 upgrade

subscribe

In general, I believe it's a pretty bad idea to have a Drupal 6 site running on php 5.3 at this time. While core should work fine, many contrib modules will throw you warnings...

@askibinski that's right, and that's why we must report the warnings and failures to module maintainers because we will all eventually need to upgrade to PHP 5.3 and beyond.

thanks, I fixed that warning. Please reopen if you find more problems.

I recently came across another rules reference warning, this time with: rules_forms_form_alter

This patch fixes the newly discovered php 5.3 reference warning.
Please check to make sure this is a safe change.

edit: I want to emphasize: Please make sure that it is safe to remove the & at this location.

My patch may not be the correct fix, see my post here:
http://drupal.org/node/360605#comment-2340170

You may want to double check the original fix as well.

Thanks for spotting this. I think removing the reference was fine for the previous one, but in this case it's probably not. But I suppose hook_form_alter() is only called by core? So in that case it need to be fixed there.

when i delete a rule from rule set, i got this error
warning: call_user_func_array() expects parameter 2 to be array, string given in /home/mysite/public_html/sites/all/modules/rules/rules/rules.module on line 851.

@spacereactor: Please create a new issue. This helps us stay organized and work with the many issues people post.

@spacereactor Issue and patch here: #878124: PHP5.3 warning: call_user_func_array() expects parameter 2 to be array