error editing condition after php 5.3 upgrade
drasgardian - September 26, 2009 - 02:15
| Project: | Rules |
| Version: | 6.x-1.x-dev |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
| Issue tags: | PHP 5.3 |
Description
After upgrading to php 5.3 I started receiving this error:
warning: Parameter 2 to rules_admin_form_edit() expected to be a reference, value given in [site_path]/drupal-6.14/includes/form.inc on line 371.
To fix it I took the "&" off the &$proxy parameter on this line:
function rules_admin_form_edit(&$form_state, &$proxy, $element) {
#1
subscribe
#2
In general, I believe it's a pretty bad idea to have a Drupal 6 site running on php 5.3 at this time. While core should work fine, many contrib modules will throw you warnings...
#3
@askibinski that's right, and that's why we must report the warnings and failures to module maintainers because we will all eventually need to upgrade to PHP 5.3 and beyond.
#4
thanks, I fixed that warning. Please reopen if you find more problems.
#5
Automatically closed -- issue fixed for 2 weeks with no activity.
#6
I recently came across another rules reference warning, this time with: rules_forms_form_alter
This patch fixes the newly discovered php 5.3 reference warning.
Please check to make sure this is a safe change.
edit: I want to emphasize: Please make sure that it is safe to remove the & at this location.
#7
My patch may not be the correct fix, see my post here:
http://drupal.org/node/360605#comment-2340170
You may want to double check the original fix as well.