The themable function which controls the ouput which defaults to 'More information about formatting options' looks like this:

function theme_filter_tips_more_info() {
  return '<p>'. l(t('More information about formatting options'), 'filter/tips') .'</p>';
}

It seems that Better Formats overrides it: if you make changes to the filter tips in Better Formats and use the above function, then the changes you make in filter tips are what is used. This doesn't seem quite right to me; surely theme_filter_tips_more_info() should have the final say over what is outputted?

Great module, by the way - should make its way to core I think, especially the bits that let you turn all of the "filter tips" cruft off.

Comments

dragonwize’s picture

dragonwize commented
Category: bug » support
Status: Active » Fixed

Overriding theme_filter_tips_more_info() is part of the feature of controlling the filter tips. However, while BF overrides this function, it does it in a themable drupal way.

If you still want to override that function in your theme while using BF, you simply override theme_better_formats_filter_tips_more_info() instead.

/**
 * Theme function for fitler tips more info.
 *
 * This is copied from theme_fitler_tips_more_info() with small modifications.
 *
 * @return
 *  Filter tips more info HTML.
 */
function theme_better_formats_filter_tips_more_info() {
  $text = variable_get('better_formats_long_tips_link_text', '');
  if (module_exists('i18n_strings') && $text) {
    $text = tt($text);
  }
  else {
    $text = $text ? $text : t('More information about formatting options');
  }
  return '<p>' . l($text, 'filter/tips') . '</p>';
}
jim0203’s picture

jim0203 commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.