Hi,

I'm using the wonderfull FileField Insert module in conjunction with a setup that can't use clean URLs and does want to use the private download method for security reasons. I also set up a few Image Cache profiles in order to insert images using a given profile thus reducing i.e. the size of images inserted into the text.

I fixed two bugs in FileField Insert that I found using this combination:

  1. FileField Insert doesn't check for private file download. This results in not replacing image cache profiles properly.
  2. When used with non clean URLs, FileField Insert replaces the "?q=" with "%3Fq=" which results in a broken link.

Please take a look at my patch. Since I still feel rather new to Drupal developement (although using it for about a year now), I'd like to get some feedback on how I solved the problem (especially the non clean URL fix, which simply replaces back "%3Fq=" to "?q=" without checking if clean URLs are disabled)

BTW: I patched against the HEAD revision in the CVS.

CommentFileSizeAuthor
ffi.patch1.89 KBskybow

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Closed (fixed)

I've deprecated FileField Insert module in preference of the new Insert project, which should not have this problem. Closing in preparation for shutting down this queue.