Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.At the moment one can search for, create and directly reference nodes from the nodereference widget in a modal frame, but if a user needs to make a quick change to a referenced node while editing the parent, they have to first view the node in the external window then edit manually. It'd save a lot of time if one could simply have a further operation exposed to the widget to edit a referenced node in the modal frame. One use case is when adding new nodes from the modal frame and I've forgotten to add a small detail in the node. This would allow me to make the change with minimal user navigation, and without breaking the workflow off adding or editing nodes from the parent window.
Downsides I can see are UI clutter with too many icons in the widget, and problematic integration with the current tabs in the modal frame.
Any thoughts?
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | edit_pre_render.patch | 1.01 KB | Ozeuss |
| #4 | 4_edit-link-modalbox.patch | 4.4 KB | jvandooren |
| #3 | edit-link-modalbox.patch | 4.4 KB | jvandooren |
Comments
Comment #1
markus_petrux commentedSomething like this would have to be optional, so it also adds clutter to the Nodereference extras tab in the administration section.
I do not plan to do add this feature myself, though I'm open to review patches as far as this is optional and it is well resolved in the modal frame as well as in the admin page.
On the other hand, the node edit form is just at a single click from there, via view referenced node in new window. Not too bad. So I'm not sure if it really worths the effort to implement such a feature.
Comment #2
markus_petrux commentedI marking this as won't fix, but just because I do not plan to do it. Feel free to re-open if you want to work on a patch as described in #1, however.
Comment #3
jvandooren commentedHello
I needed this functionality too and got started on something.
This patch changes the functionality behind the "view" button. It will not open the node view in a new tab/window. It will now open the edit node view in a modalbox. You can change what you want in the node, and click save. The modalbox will close and the reference field will be updated. I needed this because I'm using Automatic Nodetitles based on editable CCK fields in my node.
Now, I didn't create this patch for general use. This patch only fits my needs.
I only published this so people can build something decent, maybe starting from my functionality.
Comment #4
jvandooren commentedDue to a small bug in my previous patch:
Comment #5
markus_petrux commentedThis feature request depends on: #735358: Redesign the "Node reference extras" tab so that we can manage more options for each node reference field
Comment #6
markus_petrux commentedAdded edit icon to sprite and CSS updated for the new edit button.
-- Patch: http://drupal.org/cvs?commit=367626
-- Sprite: http://drupalcode.org/viewvc/drupal/contributions/modules/noderelationsh...
Comment #7
markus_petrux commentedOk, committed to CVS.
http://drupal.org/cvs?commit=367644
Thanks!
Comment #8
Ozeuss commentedI've noticed that in the last patch, _noderelationships_child_edit_form_alter(&$form) doesn't call the pre-render function like the "create" form.
I guess that we don't to show tabs for edit form (since it doesn't make alot of sense to show both "create" and "edit" tab), But what I miss is the page prefix and suffix (which inserts the div). Adding the pre-render call makes the UI more consistent because of this.
I added a simple patch.
Comment #9
Ozeuss commentedComment #10
markus_petrux commentedGood catch. Thanks!
Patch committed, but also changed the pre-render callback code to avoid PHP notices, because the tabs are only rendered for "Search and reference" and/or "Create and reference". For "Edit referenced node" we do not render tabs.
http://drupal.org/cvs?commit=374356