Make swftools' onepixelout compatible with PHP 5.3
Boobaa - September 27, 2009 - 15:17
| Project: | SWF Tools |
| Version: | 6.x-2.5 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
| Issue tags: | PHP 5.3 |
Jump to:
Description
Upgrading to php-5.3 renders swftools' onepixelout unusable with barking like these:
warning: Parameter 2 to onepixelout_swftools_flashvars() expected to be a reference, value given in /path/to/drupal/includes/module.inc on line 450.
Removing the ampersands from onepixelout_swftools_flashvars()'s definition renders swftools' onepixelout usable again - which is what the attached patch does.
| Attachment | Size |
|---|---|
| swftools_onepixelout-php-5.3.patch | 434 bytes |
#1
Tested and this fixes the problem. (Drupal core was also fixed with similar changes in drupal 6.14 I think).
Similar changes will also need to be done for all the modules that use hook_swftools_flashvars.