I have created a module that implements a Views style plugin. In my hook_views_plugins() implementation I have defined the 'help topic' attribute for the style plugin entry, and I have also implemented the help subdirectory and all the rest of the advanced help stuff.

It all works well, except the help icon is not displayed next to the title of the style plugin settings form.

The problem is that views_plugin_display.inc does not set the #help_module attribute in the $form array, assuming all help icons are implemented by Views.

Patch coming...

CommentFileSizeAuthor
#2 views_help_topic-589484-2.patch1.44 KBmarkus_petrux
#1 views_help_topic-589484-1.patch1.45 KBmarkus_petrux

Comments

markus_petrux’s picture

markus_petrux commented
Status: Active » Needs review
StatusFileSize
new views_help_topic-589484-1.patch1.45 KB
markus_petrux’s picture

markus_petrux commented
StatusFileSize
new views_help_topic-589484-2.patch1.44 KB

Oops! fixed copy/paste issue. Sorry.

markus_petrux’s picture

markus_petrux commented

How to test:

If you do not have a style plugin at hand implemented by a separate module that provides its own help topic, then you may want to try with this one:

http://drupal.org/project/views_fluid_grid

When the style plugin settings form is rendered, there's no help icon to the left of the title "Defaults: Style options". If you apply the patch in #2, you will now see the small help icon, as if it was any other style plugin implemented by Views itself. :)

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed to all branches. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.