Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a placeholder issue. This is a must for Panels.
Comment | File | Size | Author |
---|---|---|---|
#33 | ctools_d7.patch | 19.09 KB | dmitrig01 |
#32 | ctools_d7.patch | 41.31 KB | dmitrig01 |
#26 | ctools_d7.patch | 41.31 KB | dmitrig01 |
#20 | ctools.HEAD_.20.patch | 53.77 KB | sdboyer |
#17 | ctools-HEAD.14.patch | 47.8 KB | dmitrig01 |
Comments
Comment #1
merlinofchaos CreditAttribution: merlinofchaos commentedOn Saturday I branched and made an initial commit for the port. There's still a long, long way to go.
Comment #2
sunI'd be very happy to work on this.
Comment #3
sdboyer CreditAttribution: sdboyer commentedThis, plus the port of Panels, is my big goal for the Vancouver sprint. I'm going to try to make headway on it prior to the sprint, though, so that I can really just have a task list and gun through while I'm there. Maybe even farm some of it out :)
Comment #4
sunJust let you guys know that I started...
Comment #5
sunSecond pass.... need a break - my eyes are bleeding.
but also, FWIW, first time looking at ctools_modal_form_wrapper() makes me worry.
Comment #6
Pasquallesome doxygen changes
update_x() functions removed
more use of drupal_static()
can we have a list of files which will be removed? I guess the ajax and the advanced form functionality is in core.
Comment #7
sun@Pasqualle: Thanks for trying to help! However, at the moment those changes make no sense.
- Unnecessary changes like (unrelated) doxygen changes, we always leave out in ports.
- Update functions need to be ported, not removed; keeping the _identical_ functionality.
- I already double-checked the statics and drupal_static() makes no sense there.
Please wait with such changes until this issue (basic port to D7) has been fixed.
Comment #8
sunQuick.
I don't understand the purpose of ctools' includes/menu.inc, even after comparison to core's, but to make any sense, we need to move any tweak in there into core - now.
If there is any tweak.
Comment #9
sunJust to post something in between. I keep on having those files open in my editor since I started.
#353208: Allow for runtime-conditional local tasks (hook_menu_local_tasks_alter()) now contains a trivial, but mission critical patch to remove yet another include file from ctools.
Comment #10
sunAlright, while working on this, I realized that I was doing each one of the major upgrade steps separately in one fell swoop (instead of going through all files and nitpicking all changes for D7 in every single line).
Hence, I changed the strategy and started to commit in atomic changes:
#589636 by sun: Updated for automatic database schema installation.
#589636 by sun: Updated for all 'class' attributes are an array.
#589636 by sun: Updated .info files for D7 and new class registry.
DBTNG, File API, and hook changes are already on the way.
But, ugh, when looking at the commit messages afterwards, we have a problem:
#580342: Fix Page Manager variant import, which did not work at all.
#589342: Introduce page_manager_get_current_page() to get information about the current page manager page.
#564492: by Roger Lopez: Change default class includes from .inc files to .class.php files so they don't get read as plugins.
#590654 by fenstrat: Add submit form as a possible AJAX operation.
#534034 by DamienMcKenna: Add access rule for term ID selection.
#531522 by alex_b: Introduce ctools_static() modelled after static object handling in D7.
#541428 by viz8: User name as a context argument.
#592692 by johnskulski: use theme_links instead of theme('links') for dropdown because we do not actually want a theme to change this output.
#547686: Allow view panes to better respect the default pager settings.
#424548: Add a warning about overridng pager settings with Views AJAX.
#555802: Add an administrative title to custom content panes to make them easier to manage.
#556870: Node edit settings form context autocomplete was not working correctly.
#491884 by ayalon: Provide blank substitutions for optional contexts that do not appear.
These were not committed to HEAD, so, uhm, what do we do about that? I certainly can try to merge all those changes from DRUPAL-6--1 into HEAD now (ideally by trying to apply the patches to catch potentially changed code in already upgraded code), but I'm not sure how we want to proceed after this one-time merger.
Comment #11
sunDBTNG + File API + some smaller changes. I'll extract those too into separate commits (easy, no worries).
However, before proceeding with commits, we need to do something about #10. Another possible option would be to completely replace HEAD with DRUPAL-6--1 again and merge all changes manually in there -- most probably that approach would definitely catch all changes from DRUPAL-6--1, so we wouldn't have to worry later on.
Thoughts?
Comment #12
merlinofchaos CreditAttribution: merlinofchaos commentedI'll find some time and try to merge the changes from #10 into HEAD. I think it'll take less time than starting over. At least one of those changes actually is in HEAD (the ctools static). A couple of the changes don't apply anyhow, and a couple of them are just new .inc files.
Comment #13
sunThank you! I've seen you committed some - are those all?
Re-rolled against HEAD + some further DBTNG code I either forgot or has been introduced by those commits.
Comment #14
merlinofchaos CreditAttribution: merlinofchaos commentedThere's a couple that I still have to do because they're fairly tedious and I didn't make patch files so I pretty much either have to do them by hand or extract patches out of webcvs which is kind of a pain.
Comment #15
sdboyer CreditAttribution: sdboyer commentedPlease please please don't invest manual effort in reintegrating those patches. It's FAR easier to do in git. In fact, I'll see if I can't just do it tonight...
Comment #16
sunFYI: Also created #599640: Move hard-coded comment query options to caller to remove another bloat of duplicated core lines from ctools.
Comment #17
dmitrig01 CreditAttribution: dmitrig01 commentedThis gets it so you can enable the module with fewer errors:
Comment #18
sdboyer CreditAttribution: sdboyer commentedre: #15, the list of patches from above has been merged into HEAD. There were only four conflicts, all quite minor, and I'm pretty sure I resolved them correctly.
Comment #19
sdboyer CreditAttribution: sdboyer commentedOh eew, forgot the other part of making it easier - rerolling the patch so it applies to the updated tree. Will do tonight.
Comment #20
sdboyer CreditAttribution: sdboyer commentedI keep feeling like little pieces are probably getting borked, but...here's the re-updated patch file.
Comment #21
DamienMcKennaFYI, a related task for Panels 3: #605944: Drupal 7 port of Panels 3
Comment #22
DamienMcKennaThis module isn't in the D7CX group, is that just from lack of available hours in the day? I presume some additional help would be appreciated? :)
Comment #23
merlinofchaos CreditAttribution: merlinofchaos commentedNo, I'm not on board with the d7cx movement and I am unwilling to make commitments like that.
Comment #24
sdboyer CreditAttribution: sdboyer commented@DamienMcKenna - I'm making the general effort to see that we're ready per on D7 launch day, but am also unwilling to actually make the formal commitment.
Comment #25
sdboyer CreditAttribution: sdboyer commentedOK, doing this with patch files is just silly and less maintainable. I've committed in the patch file, along with some more additions to what was already done. I'd rather we actually commit in with informational messages, and I can easily merge in forward-ports of changes to the 6--1 branch (if they don't 'just work'). If you don't have commit access, feel free to post incremental patches to this issue, or file separate issues; I'll integrate them as needed.
Comment #26
dmitrig01 CreditAttribution: dmitrig01 commentedI did a bunch of upgrading through coder - but i haven't upgraded plugins or page_manger yet.
Comment #27
merlinofchaos CreditAttribution: merlinofchaos commentedelse if --> elseif is not an upgrade. It's a style correction. Please do not include style corrections in upgrade patches.
Comment #28
sunI agree with Earl -- that absolutely doesn't belong into a porting patch/effort. (Though I really like those changes, so please keep 'em somewhere ;)
I guess this won't work due to the new structure of permissions.
I'm on crack. Are you, too?
Comment #29
sdboyer CreditAttribution: sdboyer commentedI had the same reaction when I initially saw coder complaining about 'else if' to 'elseif'. There IS a slight difference, though; however, that only affects the colon syntax, which we never use.
I think it's worth filing an issue in coder - at minimum, it should be demoted to a 'minor' violation.
Comment #30
merlinofchaos CreditAttribution: merlinofchaos commentedYeah. The 'elseif' 'else if' debate is kind of annoying. As a C programmer originally, I default to 'else if' since C and variants do not have 'elseif'. So it's naturally 'else if' throughout my code. And it seems silly to have a coder style rule about it, since the presence or absence of the space doesn't affect readability at all.
Comment #31
dmitrig01 CreditAttribution: dmitrig01 commentedok, sorry, i was just trying to make coder shut up.
Comment #32
dmitrig01 CreditAttribution: dmitrig01 commentedOk, this shoudl be better
Comment #33
dmitrig01 CreditAttribution: dmitrig01 commentedold patch
Comment #34
sdboyer CreditAttribution: sdboyer commentedSorry for the delay, I'll try to integrate these tonight or tomorrow night - I've VERY nearly got the new tailor/bzr automated setup done!
Comment #35
Dave ReidAdding D7 porting tag...
Comment #36
Nick Lewis CreditAttribution: Nick Lewis commentedWhat do you say we open this back up? Seems like a good goal for this patch would be to get thinks working enough that ctools doesn't break the site. After which, we have a branch?
Comment #37
sdboyer CreditAttribution: sdboyer commentedYeah, now that the video has made its rounds... :P
There's some fun merging that still does need to be done to catch HEAD up to where it needs to be. Fortunately, I actually have the tools together now to be able to do that merge properly.
Comment #38
Nick Lewis CreditAttribution: Nick Lewis commentedOkay, I guess then any work should wait that patch. Just let me know how I can help beyond reviewing it once posted.
Comment #39
sdboyer CreditAttribution: sdboyer commentedI'll be committing it to the HEAD branch, at which point I'll ask folks to post their patches to here as diffs against HEAD. It's too hard to keep up with merging in the changes we're making on DRUPAL-6--1 in just a patchfile.
Comment #40
sdboyer CreditAttribution: sdboyer commentedCode has been merged in to HEAD, that's now our 7.x dev branch.
Comment #41
Nick Lewis CreditAttribution: Nick Lewis commentedSo tomorrow night, shall I get the current patch synced with head, and report back - or were portions of this patch already put in? I confess I'm only a foot soldier, and not an expert in this system and do not understand whether the comments above from October are still relevant. Marching orders will be followed however.
Or i'll try to work this out. Either way, my sense is that panels is a really *the test case* for so much of this stuff that i'm wondering how i'll tell its working if i'm upgrading this module... Not breaking d7 is a good first step i guess however lol. Can't wait to see how all those API changes from 6 to 7 effect ctools.
Comment #42
zeropaper CreditAttribution: zeropaper commented#40 is an awesome news, looking forward.
(btw, I really would like to help...)
Comment #45
Nick Lewis CreditAttribution: Nick Lewis commentedSo this is still assigned to sun. Wanted to know what the deal was: should someone grab the torch of moving the patch forward? Or is someone already doing lots of work somewhere in an undisclosed location and will be posting the first patch shortly?
Comment #46
merlinofchaos CreditAttribution: merlinofchaos commentedFYI I am not currently able to work on this at all until after the next releases of Views 3 Panels/CTools/PanelsEverywhere.
Comment #47
sdboyer CreditAttribution: sdboyer commentedForgot to reassign. Feel free to post patches.
Comment #48
merlinofchaos CreditAttribution: merlinofchaos commentedComment #49
mikeryanIn what shape is the basic plugin manager support? It seems to me that it shouldn't take very much at all to work on D7...
Thanks.
Comment #51
sdboyer CreditAttribution: sdboyer commented@mikeryan: Plugin management is pretty much entirely unaltered, at least for procedural plugins. OO plugins may be a different story, depends on how we integrate with the registry.
Comment #52
mainpc CreditAttribution: mainpc commentedSubscribing because this affects http://drupal.org/project/panels/ and http://drupal.org/project/advanced_forum/
Comment #54
klausiThere is a port on github: http://github.com/hugowetterberg/ctools
Comment #55
voxpelli CreditAttribution: voxpelli commentedIn response to #54 - that repository is just a very little quickfix to get exportables working so that the work on porting Services to Drupal 7 could begin
Comment #60
Remon CreditAttribution: Remon commentedsubscribe
Comment #61
Anonymous (not verified) CreditAttribution: Anonymous commentedsubscribe
Comment #62
Anonymous (not verified) CreditAttribution: Anonymous commentedSubscribe
Comment #63
davebv CreditAttribution: davebv commented+1
Comment #64
chawl CreditAttribution: chawl commentedsubs
Comment #65
kika CreditAttribution: kika commentedsubscribe
Comment #66
rfaysubscribe
Comment #67
Jackinloadup CreditAttribution: Jackinloadup commentedsubscribe
Comment #68
klausiD7 version is in CVS HEAD now.
Comment #69
sdboyer CreditAttribution: sdboyer commentedUh. Not even a little fixed.
Comment #70
bpeter CreditAttribution: bpeter commentedSubscribing
Comment #71
Daniel Norton CreditAttribution: Daniel Norton commented++
Comment #72
mahfiaz CreditAttribution: mahfiaz commentedSubscribing
Comment #73
Averiz CreditAttribution: Averiz commentedIm just a lowly theme designer with little php knowledge. Panels is a must have module. So I'm happy to help with testing or gui input. Or whatever else I can do to further the project along.
Comment #74
sdboyer CreditAttribution: sdboyer commented6.x-1.x has been rolled back into HEAD.
Comment #75
jennycita CreditAttribution: jennycita commentedsubscribe
Comment #76
FiNeX CreditAttribution: FiNeX commentedsubscribe
Comment #77
chichiMi5 CreditAttribution: chichiMi5 commentedsubscribe
Comment #78
gaelicWizard CreditAttribution: gaelicWizard commentedsub.
HEAD seems to report version 6. Where do I get the (in progress) code for 7?
Comment #79
Pasquallehttp://drupal.org/node/343333/release?api_version[]=103
Comment #80
Remon CreditAttribution: Remon commented@Pasqualle, cvs release is a lil bit old. Try this one http://github.com/sdboyer/ctools
Comment #81
sdboyer CreditAttribution: sdboyer commentedClosin this sucker out in favor of individual issues, now that we've just about wrapped the code sprint.
Once I'm back from vacation (the 27th), I'll be remerging the changes made in the repository noted in #80 back into HEAD.
Comment #82
Dave ReidSo, can we have a 7.x-1.x-dev release yet?
Comment #83
merlinofchaos CreditAttribution: merlinofchaos commentedNot until our git workspace is merged back into CVS next week.
Comment #85
groovehunter CreditAttribution: groovehunter commentedsub
Comment #86
BenK CreditAttribution: BenK commentedSubscribing...
Comment #87
rwohlebsubscribing
Comment #88
michaek CreditAttribution: michaek commented7.x-1.x-dev?
Comment #89
iaminawe CreditAttribution: iaminawe commentedsubscribe
Comment #90
Dave ReidIs exporting back to CVS really this big of a pain? I'll volunteer to pull from someone's Git and commit to CVS if desired. Re-opening as the project does not contain any of the new recent code yet.
Comment #91
rfayIt would be nice to have a release of some type, as I know that several modules now depend on (some) github version of this, but it's not easy to figure out what version one should use.
Comment #92
merlinofchaos CreditAttribution: merlinofchaos commentedsdboyer said he was going to do this on Friday. It hasn't happened.
But re-opening this issue is interpreted as yelling at us, and that's not appreciated giving the assload of work we've done over the last month. Please be patient.
Also, closing and locking this issue. It's not at all useful, other than spamming my inbox with +1 subscribes.