The module ignores the title specified in the basic settings of the display, and the help text for the GeoRSS form is broken on the Safari browser (it's outside the collapsed region so that it overlaps with the update button).

Changing a few lines as in the attached patch allows the title to be overridden and fixes the form.

CommentFileSizeAuthor
views_rss.diff1.76 KBchungyc

Comments

rsoden’s picture

rsoden commented
Title: Overriding title and fixing GeoRSS form » Overriding title
Assigned: Unassigned » rsoden

chungyc, thanks. I committed your changes to the GeoRSS form.

RE: the title - the current code provides $sitename | $display name as the title for outgoing feeds. $view->get_title() returns mixed results unless the title is overridden for the specific display.

Agreed that the current approach is not ideal, but I don't think this fix quite gets us there.

chungyc’s picture

chungyc commented

What sort of case gives mixed results? My patch seems to work with no title set, title set only on default display, and title overridden in feed display. It doesn't work when "Use the site name for the title" is set, though, which seems to be fixed by the following code:

  // Set basic info - title, description - about the feed
  
  // new code
  if ($view->display_handler->get_option('sitename_title')) {
    $vars['viewtitle'] = variable_get('site_name', 'Drupal');
    if ($slogan = variable_get('site_slogan', '')) {
      $vars['viewtitle'] .= ' | ' . $slogan;
    }
  }       
  else 

  // from previous patch
  if ($view->get_title())
    $vars['viewtitle'] = $view->get_title();
  else
    $vars['viewtitle'] = variable_get('site_name', array()) . ' | ' . $view->display[$view->current_display]->display_title;
josephcheek’s picture

josephcheek
Location Provo, UT
commented

+1

Even if the patches don't quite get us there (how?), they are better than the current hardcoding of the title. I vote for including the diffs provided (either the first or both).

David Goode’s picture

David Goode commented
Version: 6.x-1.0-beta1 » 6.x-1.x-dev
Assigned: rsoden » David Goode
Status: Active » Fixed

Agreed, this makes sense. Just copied the code from theme.inc into this display handler's theme and committed. Good call.

Thanks,
David

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.