Anonymous don't, in general, have a session any more. Therefore it's not possible to count how many there are.
The Who's online block always displays the number of (registered) users, but for some reason #201122: Drupal should support disabling anonymous sessions made the block also display the number of "guests" when (and only when) page caching is disabled. This code can I think all be safely removed. The <h3> heading "Online users" in the block itself can also probably be removed.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 590092_3.patch | 5.74 KB | baldwinlouie |
| #8 | 590092_2.patch | 6.01 KB | baldwinlouie |
| #6 | 590092_1.patch | 4.86 KB | baldwinlouie |
| #3 | 590092_0.patch | 2.46 KB | baldwinlouie |
| #1 | 590092.patch | 2.42 KB | baldwinlouie |
Comments
Comment #1
baldwinlouie commentedHere is a patch that removes the code described above
Comment #3
baldwinlouie commentedrerolled
Comment #5
gpk commentedNeed to remove code for anonymous users/sessions from user.test, including 1 assertion. Also there is text output onto the block's configuration page, and also on the system performance page, about the interaction with page caching, that needs to go.
Comment #6
baldwinlouie commentedreroll with user.test changes and the block configuration change.
I'm not seeing the interaction with page caching on the system performance page though.
Comment #7
gpk commented>I'm not seeing the interaction with page caching on the system performance page
Yes I'm not seeing it either, for some reason it's not working and I just get a few errors such as:
The code is there in block.module, see http://api.drupal.org/api/function/block_form_system_performance_setting...
Comment #8
baldwinlouie commentedrerolled. @gpk, I removed all the code you suggested.
Comment #9
baldwinlouie commentedComment #10
catchThis removes some horrible text that few people will understand, and a feature that will make zero sense with the new session handling - if you have page caching off, and that block enabled, then your site makes no sense. It's a bit of a shame, because that block is nice for vanity, but not enough of a shame to stop this being RTBC.
Comment #11
dries commentedThis patch needs a quick re-roll.
Comment #12
dries commentedComment #13
baldwinlouie commentedrerolled.
Comment #14
catchreRTBCed.
Comment #15
damien tournoud commented?!?
Comment #16
baldwinlouie commented@Damien, not sure what I should do here. I removed the title stated in the original bug report.
Comment #17
gpk commentedOh yes, I see what Damien is asking.
Currently the block might look something like
WHO'S ONLINE
There are currently 3 users and 8 guests online.
Online users
- Damien
- Dries
- Moshe
What I proposed in the original issue was that the h3 "Online users" is now superfluous, since the block will only ever report online users, as follows according to my suggestion:
WHO'S ONLINE
There are currently 3 users online.
- Damien
- Dries
- Moshe
Comment #18
dries commentedThe patch looks correct to me. Not sure what DamZ comment was about, but we can follow-up on it if necessary.
Comment #19
gpk commentedThanks Dries, possibly Damien hadn't realised that the removal of the "Online users" heading was intentional, or perhaps he was (also) flagging up the incorrect key 'titles' passed to theme_user_list in the original (should have been 'title'). Either way I think this is correct now.