right now flexinode/table/ does, tablesort_pager() does not longer exist and can not be used.
attached patch fixes that.

Comments

samc’s picture

Title: flexinode/table/ does not work » Call to tablesort_pager fails -- 4.7 compatibility issue
Priority: Normal » Critical

+1

Bèr Kessels’s picture

can anyone please post a short note on whether or not this patch works and solves the problem?

Bèr Kessels’s picture

Status: Reviewed & tested by the community » Needs review
Bèr Kessels’s picture

Status: Needs review » Fixed

NM, tested it myself. Committed

bot’s picture

Assigned: Unassigned » bot
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new642 bytes

ha, after adding some more elements to the table i now realise that
the last params has to be an array and not 0.

bot’s picture

Assigned: bot » Unassigned

since the last 2 params are default,
it would be cleaner and also working to just use:
$output .= theme('pager', NULL, 20);

PakWaan’s picture

Status: Reviewed & tested by the community » Needs work

Ever since installing patch #1, every page on my Drupal site now has "20," in the upper left side before the rest of the page draws.

???

Also, patch #1 fixes the issue which patch #0 caused where the table would only display the first page of results - clicking "next" would always return page #1. ( http://drupal.org/node/59099 )

PakWaan’s picture

Status: Needs work » Reviewed & tested by the community

The "20," issue went away when I re-downloaded the CVS version and applied the patch again - must have been something I did.

By the way, the other issue (paging to 'next' page didn't work) has indeed been fixed by version #1 of this patch. Fixed 2 problems with 1 line of code!

Thanks

Bèr Kessels’s picture

can someone please give a cler review if the last patch #5 does solve the trick and does not open new issues?

samc’s picture

StatusFileSize
new634 bytes

Ok. Verified that patch_0 doesn't work. (Note to self: maintain a separate test setup w/ warnings on!)

Also verified that patch_1 *does not* work. (Yields "Warning: Illegal offset type in C:\Program Files\XAMPP\htdocs\drupal\includes\pager.inc on line 124").

The approach outlined in #6 (omit $element param and $parameters array) DOES work. Patch rolled, tested and attached.

samc’s picture

StatusFileSize
new693 bytes

Didn't notice it, but there's a redundant line of code in the same area fixed by this patch.

Looks like the previous patch has already been committed, so the attached patch is incremental to the previous one.

It simply removes a superfluous call to drupal_set_title().

Bèr Kessels’s picture

Status: Reviewed & tested by the community » Fixed

Committed. thanks

Anonymous’s picture

Status: Fixed » Closed (fixed)