right now flexinode/table/ does, tablesort_pager() does not longer exist and can not be used.
attached patch fixes that.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 59035_incremental_0.patch | 693 bytes | samc |
| #10 | 59035_3.patch | 634 bytes | samc |
| #5 | flexinode.patch_1.txt | 642 bytes | bot |
| flexinode.patch_0.txt | 632 bytes | bot |
Comments
Comment #1
samc commented+1
Comment #2
Bèr Kessels commentedcan anyone please post a short note on whether or not this patch works and solves the problem?
Comment #3
Bèr Kessels commentedComment #4
Bèr Kessels commentedNM, tested it myself. Committed
Comment #5
bot commentedha, after adding some more elements to the table i now realise that
the last params has to be an array and not 0.
Comment #6
bot commentedsince the last 2 params are default,
it would be cleaner and also working to just use:
$output .= theme('pager', NULL, 20);
Comment #7
PakWaan commentedEver since installing patch #1, every page on my Drupal site now has "20," in the upper left side before the rest of the page draws.
???
Also, patch #1 fixes the issue which patch #0 caused where the table would only display the first page of results - clicking "next" would always return page #1. ( http://drupal.org/node/59099 )
Comment #8
PakWaan commentedThe "20," issue went away when I re-downloaded the CVS version and applied the patch again - must have been something I did.
By the way, the other issue (paging to 'next' page didn't work) has indeed been fixed by version #1 of this patch. Fixed 2 problems with 1 line of code!
Thanks
Comment #9
Bèr Kessels commentedcan someone please give a cler review if the last patch #5 does solve the trick and does not open new issues?
Comment #10
samc commentedOk. Verified that patch_0 doesn't work. (Note to self: maintain a separate test setup w/ warnings on!)
Also verified that patch_1 *does not* work. (Yields "Warning: Illegal offset type in C:\Program Files\XAMPP\htdocs\drupal\includes\pager.inc on line 124").
The approach outlined in #6 (omit $element param and $parameters array) DOES work. Patch rolled, tested and attached.
Comment #11
samc commentedDidn't notice it, but there's a redundant line of code in the same area fixed by this patch.
Looks like the previous patch has already been committed, so the attached patch is incremental to the previous one.
It simply removes a superfluous call to drupal_set_title().
Comment #12
Bèr Kessels commentedCommitted. thanks
Comment #13
(not verified) commented