Patch to add functionnality + bugs fixes
sinasquax - September 28, 2009 - 18:45
| Project: | Textimage |
| Version: | 6.x-2.1 |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Description
Hello, i have made a patch to correct these bugs :
- Bug when language negotiation is setted on 'Path prefix with language fallback', the path of image has the prefix added
- Some fonts are cutted, moved the margins code before the text code so we can add margins to avoid font cutting
- When we have not access for creating image, the page was returned two times because drupal_access_denied was called without exit after
And for adding these functionnality :
- Modified theme function like the dev version to return the path of the image also
- Added the option 'UPPERCASE without accent' in preset options
- Added filter management (like signwriter, most of filter code is copied from this module)
| Attachment | Size |
|---|---|
| textimage.zip | 16.36 KB |
#1
Hi sinasquax,
Thanks for taking the time to do some work on Textimage, however, can I request that you submit a patch so that I can better review the changes you have made? Checkout http://drupal.org/patch/create for more information on how to do so.
As for the changes, it's generally best not to make more than one change per patch as it can make it difficult for the maintainer (me) to actually determine what each change in code is related to, but I can't tell if that is an issue yet until I have a patch to look at, so I'll excuse that for the time being.
Look forward to reviewing the code.
#2
Hi, i have attached patches, tell me if you want that i split them by change.
Thank you