attachements added before pressing preview on the issue tracker are lost
and one has to add them again.

if one selects an attachment before switching to preview the
attachement should stay in the attachment field.

CommentFileSizeAuthor
#4 project_file_previews.patch1.46 KBhunmonk

Comments

dww’s picture

dww
we/he/they
commented
Version: » 4.7.x-1.x-dev
Priority: Normal » Critical

this is a serious pain in the ass. we should fix it ASAP.

dww’s picture

dww
we/he/they
commented
Project: Project » Project issue tracking
Version: 4.7.x-1.x-dev » 5.x-2.x-dev
Status: Active » Fixed

this seems to be fixed in the HEAD version of project_issue.module (5.x-0.x-dev for now), so i'm marking this fixed. see also http://drupal.org/node/148689 as a related issue in terms of cleaning up the file attachment UI during previews.

aclight’s picture

aclight commented
Status: Fixed » Active

I've noticed this behavior for at least a few days now. I assume d.o is running the HEAD version, right? So if so, then maybe the problem isn't fixed, or perhaps it was fixed but then was broken again.

AC

hunmonk’s picture

hunmonk commented
Assigned: Unassigned » hunmonk
Status: Active » Needs review
StatusFileSize
new project_file_previews.patch1.46 KB

attached patch fixes. tested as working w/ both new issues and issue followups, whether no file is uploaded, or it's changed, or whatever. since file_check_upload() caches it's work, there's no issue with it getting called again during the validation code.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Reviewed & tested by the community

Code style looks good. I don't have time to test this myself, but I trust hunmonk's thorough testing...

hunmonk’s picture

hunmonk commented
Status: Reviewed & tested by the community » Fixed

fixed in HEAD, 4.7.x-1.x, 4.7.x-2.x

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)