attachements missing after pressing preview
bot - April 16, 2006 - 22:16
| Project: | Project issue tracking |
| Version: | 5.x-2.x-dev |
| Component: | User interface |
| Category: | bug report |
| Priority: | critical |
| Assigned: | hunmonk |
| Status: | closed |
Description
attachements added before pressing preview on the issue tracker are lost
and one has to add them again.
if one selects an attachment before switching to preview the
attachement should stay in the attachment field.
#1
this is a serious pain in the ass. we should fix it ASAP.
#2
this seems to be fixed in the HEAD version of project_issue.module (5.x-0.x-dev for now), so i'm marking this fixed. see also http://drupal.org/node/148689 as a related issue in terms of cleaning up the file attachment UI during previews.
#3
I've noticed this behavior for at least a few days now. I assume d.o is running the HEAD version, right? So if so, then maybe the problem isn't fixed, or perhaps it was fixed but then was broken again.
AC
#4
attached patch fixes. tested as working w/ both new issues and issue followups, whether no file is uploaded, or it's changed, or whatever. since file_check_upload() caches it's work, there's no issue with it getting called again during the validation code.
#5
Code style looks good. I don't have time to test this myself, but I trust hunmonk's thorough testing...
#6
fixed in HEAD, 4.7.x-1.x, 4.7.x-2.x
#7