mearnest [mearnest]

As I have already written, first one application is approved, and then the other user may ask to get a CVS account to become co-maintainer of the module (in the case the first application is approved).

Having two different applications for the same module is only confusing.

1. The module should use Drupal Unicode functions, when there is such functions.
2. The indentation used in some cases is not two spaces.

3.   foreach ($user->locations as $location) {
   

   That code would cause an error wrong argument passed to foreach(), in the case $user->locations is undefined.

4.     '#attributes' => array('onchange' => 'apply_address(\''. $type .'\', this.value); '),
   

   The code should use a different method to attach a JavaScript function to a form field event (it could use Drupal behaviors, in example).

1. If you are going to unconditionally include a PHP file, it would be better to merge it with the module file.
2. Drupal Unicode functions include also drupal_strlen(), which should be used instead of strlen().

3. function _uc_location_order_to_location(&$order, $type) {
     // Queries database for the zone code and name based on order zone number.
     $zone = db_fetch_object(db_query("SELECT zone_code, zone_name FROM {uc_zones} WHERE zone_id = %d", 
                                      $order->{$type .'_zone'})
                                     );
     // Queries database for the country iso code and name based on order country number.
     $country = db_fetch_object(db_query("SELECT country_iso_code_2 as country_code, country_name FROM ". 
                                         "{uc_countries} WHERE country_id = %d", 
                                         $order->{$type .'_country'})
                                        );
   
   

   The indentation should be changed (it suddenly passes from two spaces to 36 spaces). Concatenating two literal strings to build a SQL query is useless.

Thank you for the updates! I have already approved your CVS account.