Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I ran this module through Coder and fixed/cleaned up a few things as a result. Attached are patches with these changes.
One important one was changing $_SERVER['REQUEST_URI'] to request_uri(). Apparently it can be a security issue...
| Comment | File | Size | Author |
|---|---|---|---|
| gtranslate_links.module.patch | 5.56 KB | Anonymous (not verified) | |
| gtranslate_links.info.patch | 423 bytes | Anonymous (not verified) |
Comments
Comment #1
blinkingtwelve commentedThanks a bunch! It's in CVS HEAD.
I will not apply gtranslate_links.info.patch, for the following reasons:
a) the packaging script adds the 'core=' stanza, so not adding it myself does not break anything
b) I do not wish to hardcode 'core=$ver' into the .info because then I'll have to maintain a separate version of this file for each Drupal major version. Right now, any recent release will run on both D5 and D6, because of a)
Comment #2
Anonymous (not verified) commentedAh, didn't know that. I was going off this: http://drupal.org/node/231036 where it says core is required...