Update Error "Call to undefined function _subscriptions_send_intervals()"

Ouch, yes, I see the problem — I'll have a fix in an hour or two.

Thanks

@venusrising:

Well, it looks scarier than it is. You can safely ignore the error.

What you've lost are the current last_sent times of your users, but they'll be replaced automatically.

This means, if you have a user with a send_interval of a week, and they received a notification yesterday, they shouldn't get the next one until next week, but because the last_sent times were lost, they'll get the next one immediately. This is a one-time glitch, and the once-a-week rhythm will be back in place automatically after that.

Nonetheless, I'll release 1.2 today to spare others from the unpleasantness of encountering an update error.

Thank you for your quick report!

@venusrising:

I'm puzzled why you get this error at all. When I run update.php under Drupal 6.13, it does load the 'subscriptions.admin.inc' file, which is apparently not loaded on your site.

The reason for loading on my plain-vanilla Garland test site is that the theme registry is rebuilt, and 'subscriptions.admin.inc' is loaded because it contains the theme_subscriptions_form_table() function, which is advertised in subscriptions_theme() in subscriptions.module.

Could it be that you've overridden (i.e. provided your own) *_subscriptions_form_table() function in a custom theme?

This would explain why this error hasn't been reported for 6.x-1.x-dev before it was released as 6.x-1.1.

I am running 6.14 and do not have any custom forms but subscription block was enabled if that helps.

When I disabled all subscription modules etc then re-enabled it went away?

Not "custom form" but "custom theme". My guess is that if you were using the Garland theme, this would not have happened. It's surprising that the theme should make a difference for update.php, but apparently it does here. That is undesirable and I'll add a

to subscriptions_update_6101() to avoid this dependency, but it seems like this is less urgent than I had thought in the beginning, because no one else is reporting seeing this issue. I've updated 6.x-1.x-dev, but I won't make a 6.x-1.2 release just yet.

When I disabled all subscription modules etc then re-enabled it went away?

I don't understand what you're trying to ask or tell me here. Is the update still pending and you can't get over it? If that's the case, then do this:

1. First try to temporarily switch to Garland and run update.php. Please let us know whether this allows the update to complete or not. If Drupal continues to require running update.php, then

2. add the line above at the beginning of subscriptions_update_6101() and run it once more.

Either way you'll get some database errors (the table and index have already been created and possibly lines inserted into subscriptions_last_sent), but you can ignore these. #1 or #2 should allow the update to complete.

(I'll be on the road for the rest of the week and may not be able to reply until I get back.)

[EDIT: #1 apparently doesn't help.]

I got the same error on a Drupal 6.14 install using a Zen-based theme.

1. Switching to Garland did not help.

2. Adding the include_once-statement right at the beginning of subscriptions_update_6101() gave a bunch of errors (this may obviously be the wrong place, but I'm not a developer), moving it below $schema['subscriptions_last_sent'] = array(...); did solve the issue.

Thanks for chiming in, guidot!

Re 1: I wish I knew what was causing this. According to http://drupal.org/project/usage/subscriptions we had 372 known sites that upgraded to 6.x-1.1 a week ago (on Sep 27), and you're only the second person to report this issue. I still maintain that it's an "unusual" problem...

Re 2: It should not matter where you insert the include_once statement. Right above the foreach is the preferred place, because that's where _subscriptions_send_intervals() will be needed, but at the top of the function should work just as well. Too bad you didn't cut&paste at least the first of those messages.

I committed the fix on Sep 30, but I'm leaving this active as a signpost until 1.2 is out.

If others encounter this issue when upgrading to 1.1, then please let us know, so we get an idea of how frequent it is.

I still have the error-messages. I used drush. So here you are:

@guidot: As far as I can see, these errors are all caused by rerunning the same update again after they've already run. Update 6101 creates a table, creates an index, and inserts some rows. At least the first two operations completed successfully the first time, and they will fail when you run the same update again. This is normal Drupal behavior.

I'm not sure whether the INSERT succeeded or not — the log format is not very clear. As I explained in #3, the INSERT is a nice-to-have, but if it fails it's only a minor glitch.

Is the Update 6101 still shown as pending for you?

Is the Update 6101 still shown as pending for you?

@salvis: No, not anymore.

And thank you for your detailed explanantions!

Had this error show up when upgrading from 6.x-1.0 (6.14). Used the suggestions in #7; #1 did not work, #2 did.

Thank you for your feedback — I added a note in #7.

You are only the third person out of over 500 updaters. I'm still puzzled what could be causing this.

I got this error too when running update.php. Doesn't look like release 1.2 got out.

Yes, there's a trade-off between raising update alarms for a thousand sites and fixing a one-time issue that less than one percent of the upgraders encounter.

Ok, but I'm still not sure how to get rid of it. Tried modifying the .install file so that the function is included specifically using:

include_once drupal_get_path('module', 'subscriptions') .'subscriptions.admin.inc';

However that didn't seem to get anywhere.

Also remember that for every bug reported there are at least 10 folks who just say "hey, this module's bust, I'll have to remove it and wait for the next release to try it again".

So, the numbers of users who have problems is likely higher than you think.

What do you mean with "to get rid of it"? What is it that you want "to get rid of"?

In the light of #3, what makes you think that you need to do anything?

Ran into this issue doing a site upgrade from D5 to D6..

I can confirm that the current dev release works around this issue, no more errors :) Thanks!