Posted by derhasi on September 29, 2009 at 7:27am
| Project: | Smileys |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
Smileys module seems to unecessarily overwrite some jquery-ui functions. This happened to me when using jquery_update, and jquery_ui (with latest jquery ui 1.7). In my case .draggable() did not work anymore.
It seems that one part of jquery_ui (ui.core.dialog.js) has been forgotten to be switched off, when jquery_ui is active.
The attached patch solved this problem.
| Attachment | Size |
|---|---|
| smileys-jquery_ui.patch | 741 bytes |
Comments
#1
Jquery_ui is unable to even install in many peoples cases and the Jquery_ui project is just deleting peoples issues on the subject. This should be removed as a functional project. They shouldn't be able to say "well it works for me" and delete peoples issues from the que.
#2
@tigerboy: i totally understand where you are comming from, but there are people who got it working and are using it. I really +1 for this update and hope you will implement it, for the users who do not use jquery_ui it will not harm nor change anything. For those that do use the ui module you will be a hero.
#3
+1 for the patch; 46k sites are reporting they have jquery_ui working properly: http://drupal.org/project/usage/jquery_ui
#4
+1 for an update. We want to integrate smileys module with our project but it is simply impossible without fixing this.
#5
i was about to type +1
but then i figured I just use it for the jquery ui calendar popup.. which I didn't need after all, so I switched it off on my site.
EDIT: I did need it so I decided to use the patch and so far it works.
in any case.. this is a problem, wether it's the smiley module's fault or jquery ui's fault, it should be addressed in the best possible way.
#6
when I apply the patch I get
in smileys.js
Line 42: $(this).dialog is not a functionI tested it with draggable and resizable set to on and off.
Without the patch when I what resizable set to on
I get
in ui.core.dialog.js
Line 1: D[G][E] is not a constructorWhen I have both draggable and resizable se to off it works without out errors (without the patch)
Manos
http://websynergy.gr/
#7
exact same issue
Line 42: $(this).dialog is not a functionnot a clue at what is causing it
#8
Thank you. This finally fixed my problem with the Smileys popup.
#9
This patch works. It's so simple and safe, why is it not applied yet? :P
#10
The first patch doesn't work. If it detects jquery_ui it won't load "ui.dialog" resulting in the error:
$(this).dialog is not a functionI fixed the problem by including "ui.dialog" from jquery_ui if it exists. Here's a new patch.