The warning
admin_system_info_alter() expected to be a reference
pops up when i switch to php 5.3 under drupal 6.14.
The warning references common.inc in drupal's includes-folder. But i'm not a coder, so I don't have a clue what's going on. Drupal for firebug appears to stay silent.

I'm not sure if it's even an admin issue because i got a list of similar warnings at update.php as well, but disabling admin removes them. So maybe something has changed?

"I'm a designer Jim, not a developer."

CommentFileSizeAuthor
#9 admin-php-5.3.patch1.1 KByhager

Comments

seworthi’s picture

seworthi commented

I had to change the following 2 line to get admin to work under PHP 5.3:

admin.module: Line 213;
Original:
function admin_system_info_alter(&$info, &$theme) {
Modified:
function admin_system_info_alter(&$info, $theme) {

theme/template.php: Line 94;
Original:
function slate_fieldset(&$element) {
Modified:
function slate_fieldset($element) {

I have not done extensive testing yet, but seems to work.

whatdoesitwant’s picture

whatdoesitwant commented

Cheers @Seworthi, it seems to work. admin is the best thing that happened to drupal6 since views. I would create a new view set before going without it.

cels’s picture

cels commented
Status: Active » Needs review

maintainers can confirm this solution and commit?

macjoyful’s picture

macjoyful commented
Component: User interface » Code

Just wanted to confirm that making the modifications is an easy fix for the php 5.3 issue. I'm a drupal newbie but definitely appreciate the look and utility of this module.

ezar’s picture

ezar commented

working fine!
please commit it.
regards,
eZar

petebarnett’s picture

petebarnett commented

I can confirm this.

As detailed in http://drupal.org/node/360605 php 5.3 throws an error when passing a value to a function that takes a reference.

Both corrections to the function signatures bring them in line with the description in D6 API documentation. theme_fieldset has $element passed as a value (http://api.drupal.org/api/function/theme_fieldset/6) and hook_system_info_alter() (http://api.drupal.org/api/function/hook_system_info_alter) has $file passed by value, not reference.

Thanks,
Peter

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Issue tags: +PHP 5.3

tagged

letsdothisdrupal’s picture

letsdothisdrupal commented

tagged

yhager’s picture

yhager commented
StatusFileSize
new admin-php-5.3.patch1.1 KB

Same fix as in #1, attached as a patch.
Works for me too.

Stasroot1’s picture

Stasroot1 commented

This work! Ok! Sory my inglish.

jpatiaga’s picture

jpatiaga commented

Patch in post #1 works for me. Thanks.

harking’s picture

harking commented
Priority: Minor » Critical
Status: Needs review » Reviewed & tested by the community

Patch worked for me too.

Changing to critical as interface is unusable in PHP 5.3.

makangus’s picture

makangus commented

worked on snow leopard

chris_gooley’s picture

chris_gooley commented

worked for me too. thanks.

EmlynC’s picture

EmlynC commented

Cheers worked for me (Ubuntu 10.4).

alexmc’s picture

alexmc commented

Patch file in #9 didn't actually work - I couldn't apply the patch normally. However I manually edited the files it was trying to patch and that worked.

(Ubuntu 10.4, 32 bit, Drupal 6. whatever is current release.)

manuel garcia’s picture

manuel garcia commented

patch doesnt apply, but the changes do work apparently. Also, the 2.x branch doesnt have this problem =)

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

+1, this works. Patch available for 4 months, R&TBC for 3 months, issue nearly a year old...? Huh?

Edit: Hmm, 6.x-1.x maintainer required I see. That explains it. Required for some time, by the looks!

Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »

This patch has been applied and committed and will be present in the next release (which will be tagged shortly).

manuel garcia’s picture

manuel garcia commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

OpenChimp’s picture

OpenChimp commented

I am running PHP Version 5.2.13 on MAMP 1.9 and am also getting this error.