Some 'Todo' implementations

Hi Tom,
Thanks for your work and for sharing it.
It would be more helpfull though if you could post patches instead of full module/install code. Its easier to review your changes, and less likely the issue cue gets polluted with all kind of module variants.
Right now I would not now where to start implementing your useful changes in a solid way.

Hi,

I downloaded the module and configured it as i thought would be good. It did not work. The return url's were not loaded correctly. The ogone page redirects to https://secure.ogone.com/cart/ogone_payment_accepted/22 for example but instead it should be http://www.urlofyourshop.com/cart/ogone_payment_accepted/22.

To achieve this with this module i added this at line 699 $url = $base_url . $url; i don't know if this is the way to do it but it works for me. I presume it would be better to add a config-field?

I am now testing the rest of the module, but for now it seems ok. Thanks!

I can confirm that this new version works well, and is a real improvement over the current 6.x version. The server-to-server status update is indispensable IMHO. It does suffer from #566168: amount too long or not numeric as well though, and the fix in #3 needs to applied as well.

The included patch can be applied on top of the latest CVS 6.x-1.x. It includes the changes in the patch 'uc_ogone_payment.module.patch' posted earlier in this thread, as well as the changes to fix #566168: amount too long or not numeric and the problem reported here at #3 by Maikel.

@arnebrasseur: thanks for combining the changes into a valid patch.
Patch is applied to CVS. I do not have the resources to test properly, so relying on community feedback before a new release.

The fix in #3 doesn't change anything for me. It still takes the ogone page as base domain and therefore I'm not redirected to my own webshop...

Hi Guys,

Thank you for the nice module.

I have done testing of the module that Tom provided. For my personal feeling it is much nicer then first version as it stores respond status to the order comments.

Regarding the problem of the redirection. This can be fixed changing function _uc_ogone_payment_url() to:

function _uc_ogone_payment_url($path, $lang = NULL) {
  global $language;

  $url_options = array('absolute' => TRUE);
  
  if (!isset($lang)) {
    $url_options += array('language' => $language->language);
  }
  if (function_exists('securepages_url')) {
    $url = securepages_url($path);
  }
  else {
    $url = url($path, $url_options);
  }
  return $url;
}

As this module works differently and even supply different menu pathes I think it would be reasonable to move it to 2 branch. What I found buggy is non existence of function uc_ogone_payment_template that is declared in menu callback for 'cart/ogone_payment_template'. Tom could you please fix this?

I have also some other improvements that needed (like using t() for text of messages, adding comments etc. but they are minor). Also cron function should be written properly. I am ready to participate in this project with patches but we need to commit Tom's version to 6.x-2.x branch.

Kees please let me know your comments about this.

More feedback: http://drupal.org/node/782028

Hi Kees,

@arnebrasseur: thanks for combining the changes into a valid patch.
Patch is applied to CVS. I do not have the resources to test properly, so relying on community feedback before a new release.

Is it really applied to CVS? In what branch?

I'm very much in favor of creating a 6.x-2.x-dev branch for this. It's getting hard to keep track of all the patches and fixes in the issue queue. The 1.4 version is close to a year old. We could keep a 1.x branch with only bugfixes, and a 2.x branch with these server-to-server calls and other new functionality.

Thanks,

Arne

Kees,

I'm wondering the same as in #9, where can we find the version to which this was committed?

Cheers