Multiple custom themes on same page
chirale - September 29, 2009 - 13:58
| Project: | jCarousel |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Jump to:
Description
Now only one custom jcarousel theme per page could be specified.
The attached patch solve this issue, using skin path for the inclusion control (now only a "custom" flag is used).
Note: Since two or more themes are used, skin.css should use a wrapper element selector to attach to the right element (e.g. a block id).
| Attachment | Size |
|---|---|
| jcarousel-multiple-custom.patch | 912 bytes |
#1
You mean having the same name for different skins? If you visit admin/help/jcarousel, you'll see there's use of different skins on the same page....
#2
This example show three different themes, but only one custom theme. This issue rises only when there are 2 or more custom skin declared in the same page, since the
$jcarousel_added['skin'][$skin] = TRUE;is set only one time when $skin = 'custom'.Creating a new array that relying also on paths for custom themes solve this issue.