Inappropriate message limit has been reached

Thank you very much for this excellent code. Would you possibly be able to create a patch for the purpose? Thanks.

Fantastic, I will review this straight away. Great work, nlahm. Appreciated.

I can confirm that this code resolves the issue for me as well.

I enabled a limit on a single role, but other admins reported that no role changes of any kind were functioning after that point. A patch or new release would be most appreciated.

Thanks!

Ok, not a problem. I will roll the patch into a new release this week. Sorry. Things crazy for me lately.

Scenario:
- Role limit had been reached.
- Edited account of someone who already had the role.
- Received limit error.

Applied patch!

Test cases:
- Same as above, but didn't receive error :)
- Tried giving role to a new person, received error, as expected.

Marked as "reviewed and tested by the community"

Nice work nlahm!

Thanks for the work, folks. I'll commit this to DEV tomorrow morning. Running out of gas, atm. :)

Committed to the 6.x DEV branch. Still needs back-porting to 5.x [EDIT, Patch didn't come through for some reason. :)]

Released to 1.9

Getting the same issue with the D7 version.

I limited the number of administrators to 1. Now, whenever I try to save any user (without attempting to grant him the administrator role), I get:

The administrator role cannot be granted to the user because the limit has been reached.

In fact, I cannot make any changes to existing user roles (neither grant nor remove existing roles). Changes to other user account fields are saved successfully.

Love the idea of this module, would really like to use it. Can anybody help?

Thanks,

Pav

Hi there. When you need to reopen an issue, just move the status to "active" and its more likely the maintainer (me, in this case) will see it. :) Currently out of my home country right now on vacation but I'll have a look at the issue this week. Thanks for letting me know.

I've needed to solve this issue myself and it looks like wrapping $edit['roles'] in array_filter() in role_limits_user_presave() does the trick by removing any roles in the array that are not selected such that we have:

function role_limits_user_presave( &$edit, &$account, $category) {
  $roles = array_filter($edit['roles']);
  if ($roles != 0) {
    foreach ($roles as $rid => $role) {
      // If the limit is more than 0, which indicates unlimited.
      $user_role = user_role_load($rid);
      if (role_limits_get_limit($rid)) {
        // If we don't find the role in the account, it is being added.
        if (!array_key_exists($rid, $account->roles)) {
          $role_count = role_limits_get_role_count($rid);
          if ($role_count == role_limits_get_limit($rid)) {
            // Reset the user roles back to the existing set.
            $edit['roles'] = $account->roles;
            drupal_set_message(t('The @role role cannot be granted to the user because the limit has been reached.', array('@role' => $user_role->name, '@user' => $account->name)), 'error');
          }
        }
      }
    }
  }
  role_limits_check_registration();
}

The subsequent if statement could probably do with some cleaning up but it seems to work as is.

I've taken a pass at cleaning up the function a little bit and a truly minor optimization of the loop.

function role_limits_user_presave(&$edit, &$account, $category) {
  $roles = array_filter($edit['roles']);
  if (!empty($roles)) {
    foreach ($roles as $rid => $role) {
      // If the limit is more than 0, which indicates unlimited.
      if ($role_limit = role_limits_get_limit($rid)) {
        // If we don't find the role in the account, it is being added.
        if (!array_key_exists($rid, $account->roles)) {
          $role_count = role_limits_get_role_count($rid);
          if ($role_count == $role_limit) {
            // Reset the user roles back to the existing set.
            $edit['roles'] = $account->roles;
            // Display unable to grant role message to the user.
            $user_role = user_role_load($rid);
            drupal_set_message(t('The @role role cannot be granted to the user because the limit has been reached.', array('@role' => $user_role->name, '@user' => $account->name)), 'error');
          }
        }
      }
    }
  }
  role_limits_check_registration();
}

@bernman, thank you! Do you want to roll that into a patch and I can get it into the module with credit for you?

Sorry for the delay in rolling the patch. There's some other areas in the code where the messages sent to the user are not being translated. But that would be for another issue :)

Moving to unassigned. Needs review.

@webkenny, any chance this could get rolled into a 1.2 release? It's been a while with no issues reported against the patch.

I've rerolled the patch against 7.x-1.x to test for changes in user roles otherwise $edit['roles'] is empty and calling array_filter() will fail.