Posted by davidwhthomas on September 29, 2009 at 11:14pm
Jump to:
| Project: | CCK Fieldgroup Tabs |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
Firstly, thanks for the excellent module, very useful!
I've been exploring an issue with adding first/last classes and found that tabs_pre_render_tabset was being called twice.
It no longer needs to be manually called as it is called by drupal_render
The attached patch removes the manual call to tabs_pre_render_tabset and saves the double processing time on form load.
DT
| Attachment | Size |
|---|---|
| cck_fieldgroup_tabs.module.patch | 679 bytes |
Comments
#1
See http://api.drupal.org/api/function/drupal_render/6 for more info
In D5 that bug may have been an issue but is no longer so.
DT
#2
I reviewed the code and believe the these lines are still needed.
The issue is that, if a theme callback is used, child elements are not themselves passed to drupal_render() and so don't get #pre_render callbacks triggered.