4.7 Update to branch 4.7 ?

i am too busy to do this myself. need help. please submit a patch here.

I'm almost done with an update.

I've attached a version that I believe is working. More testing might be useful.

this version is working, but I get only 18 nodes displayed.

Yeah, I can't get the pager function to work and I haven't had time to work on it. I'll try to find time soon.

I reviewed the module that had appeared above. I noticed that (on my Mac) the code appeared fine in TextEdit but not in TextWrangler. In TextWrangler, because of the weird wrapping that was occurring, certain parts of the code were being commented out though that didn't appear to be the author's desire (including the call to theme('pager')). I reformatted the module in TextWrangler and tested it on two of my sites and found the pager functional. I have attached the updated module (really just reformatted) and will link to a screenshot of the module in action with the pager working* - I suspect some different type of line endings might have been to blame. Please test, the module appears to be fully functional on both of my 4.7 sites on which I have it installed.

Module screenshot

Brett

*In order to get the screenshot to show the pager and all of the parts I shortened the pager limit to 5 nodes. In the module I uploaded the limit is set at 20 as was previously set in the module.

Great job! Your new code seems to work for me. Can you describe better what was going on with theme('pager') call being commented out? Because I'm just not seeing the difference and I want to know if gEdit is doing funky things to my text. (Also, you should set your tab setting in TextWrangler to 2 spaces as per the drupal coding standards.)

As for the pager limit, wouldn't it be nice if we had that as an option somewhere? ;-)

Otherwise your update seems to work great. If you want, you can change/add any comments to the file go ahead.

Thanks for the tips on the 2 space indent setting in TextWrangler, I just reviewed the coding standards end of last week and hadn't made that change yet.

I'm assuming that module showed up normally in gEdit (i.e. per drupal coding standards). If that is the case then, based on what I could tell from the module, it appeared that the line endings were coming across in a funky way (perhaps non-unix but with gEdit being a Linux app I don't know why that would happen). Thus by using the // comment symbol it commented everything out on a single line following that symbol, including the call to theme(pager) in the module. Basically the call the theme(pager) was commented out and thus the output wasn't showing up. My guess would be that gEdit is doing something funky with the code, but that's just a guess.

Can this be committed (or do I need to create a proper patch file first so then it can be committed to CVS)?

I'm not sure how one goes about committing changes. Perhaps the person managing this project knows?

I was thinking that this project could use to be extended anyways. I recently ran into the need to make mass changes to node types, so i'm attaching the module I wrote for doing that. But perhaps there should be a "multi_edit" module for common changes.

+1 on #6 patch - worked great for me.
One thing we might want to add would be a separate permission, especially if this is merged with type_multi_edit, since either of these tools could be pretty dangerous :)

Thanks for your work on this guys!

recent attachments are not patches. please read up on patch from diff and patch ... curly braces should stay on same line as function definition.

Hi Folks,

looks like Moshe left a note here about additional changes needed based on coding standards. Is anyone who has contributed interested in helping with the last changes needed?

I took the time to go through the module, and have made many fixes to the code style and formatting.
Here is a patch.

Note that the patch replaces the whole file - the 4.7 version shares essentially no code with the 4.6 version.
I have set the issue title back to something sensible - please leave issue titles as meaningful statements!

Now - who wants to update this to 5.0?!

Hi,
Wouldn't it be great if this patch would be committed so the 4.7 branch of this module is filled?

Next to this, does anybody know whether this module also works with the category.module ?

Greetings,
Martijn

I think this is old.