Separating translating browsing permissions from general access permissions lets us open up localize.drupal.org to the general public to observe progress stats. Given that we have the progress stats cached now, it should not be a performance issue anymore. Therefore I devised and committed the attached patch and granted browsing to authenticated and general access to anonymous even.
I've also added two notes to the approve/decline permissions to signal that although they look like too general, the permission checking is done later because it depends on too many other factors.
Test fixes also included, and verified that tests still pass.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | fix-welcome-screen.patch | 4.01 KB | gábor hojtsy |
| separate-translation-browsing.patch | 6.62 KB | gábor hojtsy |
Comments
Comment #1
gábor hojtsyThe welcome screen needed some tweaking as well. Now that having general access does not mean you can look up strings one by one, the welcome picker needed to have some wording changes (you cannot select both a language and project at once, or if you do, we prefer your project selection). And the project selector lacked autocomplete given that its permission were changed in the above patch. That little piece rolled back.
Works with the welcome screen much better now. Committed this too.