Closed (fixed)
Project:
Patterns
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Sep 2009 at 20:18 UTC
Updated:
15 Oct 2009 at 18:40 UTC
The current test for preventing infinite recursion prevents any pattern dependency from running twice in the same pattern. This may not be what one wants.
For example, I want to run a permissions update after each pattern is dependency is run.
If I have a pattern A which calls B which calls perm_update and then A calls C which calls perm_update the second perm_update is erroneously blocked even though there is no recursion at all.
The attached patch keeps better track of recursion so callstacks
A -> B -> A or B -> A -> A will be prevented but A -> B, A -> C -> B will not
| Comment | File | Size | Author |
|---|---|---|---|
| patterns-strict-recursion.patch | 1.06 KB | andrewlevine |
Comments
Comment #1
andrewlevine commentedoops, patch needs review
Comment #2
vaish commentedPatch committed.
Thanks