The current test for preventing infinite recursion prevents any pattern dependency from running twice in the same pattern. This may not be what one wants.

For example, I want to run a permissions update after each pattern is dependency is run.

If I have a pattern A which calls B which calls perm_update and then A calls C which calls perm_update the second perm_update is erroneously blocked even though there is no recursion at all.

The attached patch keeps better track of recursion so callstacks
A -> B -> A or B -> A -> A will be prevented but A -> B, A -> C -> B will not

CommentFileSizeAuthor
patterns-strict-recursion.patch1.06 KBandrewlevine

Comments

andrewlevine’s picture

Status: Active » Needs review

oops, patch needs review

vaish’s picture

Status: Needs review » Fixed

Patch committed.

Thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.