I ran into a problem where our theme overrode theme_links() to add some extra markup. This ended up breaking ctools drag and drop since it was using theme('links') and was not compatible with the js. (This was all in the context the Panels Display Edit)

This is obviously not just for the drag and drop functionality, but any javascript that is dependent on HTML that is rendered through theme(). We know, in the drupal world, theme() is there so users can change the html it generates so this will always happen.

I am not sure of the right solution, but I ended up creating this patch to use the default theme function.

CommentFileSizeAuthor
#1 ctools-592692.patch548 bytesjonskulski

Comments

jonskulski’s picture

jonskulski commented
StatusFileSize
new ctools-592692.patch548 bytes
merlinofchaos’s picture

merlinofchaos commented
Status: Active » Fixed

I agree, this has come up a couple of times. It should've occurred to me that the fix would be so simple, but it did not. Thanks.

merlinofchaos’s picture

merlinofchaos commented

Oh, be sure to set 'needs review' when you add a patch in the future. It is more likely it'll get noticed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.