Spaces_og's save() function uses an UPDATE query incompatible with postgresql (patch attached)

halcyonCorsair - October 1, 2009 - 03:48
Project:Spaces
Version:6.x-2.0-beta6
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Issue tags:PostgeSQL
Description

When you update a features public/private status in an og space, the UPDATE query uses INNER JOINs that fail with Postgresql.

AttachmentSize
spaces_save_og2x_update_public.patch1.2 KB

#1

halcyonCorsair - October 1, 2009 - 21:38

Oops, add {}'s around table names.

also is their a reason you changed the form of the query so much?
from joins to a subquery?
miccolis: postgres doesn't like INNER JOINs in update queries
miccolis: hmm, i think i can rewrite it to use a FROM instead of the subselect to be in a similar form, but i don't think that would work with mysql
Ok, subselect is fine.

AttachmentSize
spaces_save_og2x_update_public_1.patch 1.21 KB

#2

yhahn - October 2, 2009 - 15:02
Status:needs review» fixed

Committed. I reimplemented the same query for OG 1.0 removing INNER JOINs and using a subselect as well.

http://drupal.org/cvs?commit=270346

#3

System Message - October 16, 2009 - 15:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.