Using array_filter in strings are wrong!

Suppose empty() is enough because if testfield holds any value fieldset should be non-collapsed

Let's review other fieldsets for the same condition

CommentFileSizeAuthor
nodewords_fieldset.patch1.06 KBandypost

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Fieldset collapsed - array_filter error » array_filter() error
Status: Needs review » Fixed

Actually, the logic is reversed: only when both the values are not empty, the fieldset needs to be collapsed (the idea is to show only the form fields that don't have a value set).

I corrected the patch, and committed the code. Thanks for the report, and the patch.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Category: task » bug

I have marked [#595472] as duplicate of this report.

I am changing this report category, as this is actually a bug report.

srobert72’s picture

srobert72 commented
Status: Fixed » Active

It is not fixed, as mentionned in #587996: Warning after update Comment#3 .
I have this error with nodewords 6.x-1.x-dev (2009-Oct-03) :

warning: array_filter() [function.array-filter]: The first argument should be an array in /home/drupal/drupal/sites/all/modules/nodewords/basic_metatags/basic_metatags.module on line 380.
srobert72’s picture

srobert72 commented
Status: Active » Fixed

Sorry!
Ok it's commited in CVS.
So let's see in next automatic release today in few hours.

Thx a lot.

srobert72’s picture

srobert72 commented

Resolved with today's version : nodewords 6.x-1.x-dev (2009-Oct-04)

Thx a lot for your work

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.