Posted by deggertsen on October 1, 2009 at 3:46pm
| Project: | Storm |
| Version: | 6.x-1.x-dev |
| Component: | Storm.module |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Has any development started here? It would be really nice to have some pre-built examples.
I have been playing with views in storm and can't quite do the things I would like to because of a limit in replacement patterns (for example if you would like to output "Storm: Project Manager Title" as a link to that project managers person page) and not allowing it to use the "Assigned to" field in filters etc.
Comments
#1
See #576054: Addition of views examples module - there isn't actually going to be a new component (I will remove the component from the issues dropdown), but at somepoint will add some to the relevant modules.
If you've built any useful ones - please do export and share!
#2
Reading through your post again:
- 'Storm: Project Manager title' can be output as a link to the Storm person node. To do this, also load the field 'Storm: Project Manager nid' into the view, and use this as part of the replacement pattern.
- I'll add the filter for assigned to.
#3
@deggertson: Re the assigned to filter, are you looking for it to display a dropdown of Storm People / Storm Teams or something like that?
I've just made a few improvements to the filters just now - it is definitely possible to filter at the moment but not very user friendly as you'd need to know the node id of the person or team. I'll write a handler to make it a bit more user friendly at some point.
#4
Thanks Magnity! You've already helped so much!
So this is what I'm trying to do. I would like to create a view that lists all the projects assigned to the person currently logged in... It has been a bit difficult for me to figure out how to make this work or if it's even possible. I've attached a txt file with the code for the view I have so far. I am by no means a views expert but am learning and appreciate your help and feedback.
Thanks again!
#5
Long time, no comments...
A user can be assigned directly as a Storm Person, or indirectly in a Storm team. There probably is a way of doing the logic, but I'm not exactly sure of what it would be at the moment - it wouldn't be simple.
Will think about a way to either:
a) make it simpler
or b) figure out the way to configure it.
This should be one of the views shipped with Storm I reckon, I'm sure a lot of people would want to see this type of thing.
#6
This is pretty critical for me. Creating a view, there doesn't seem to be a way to filter on 'assigned to'. What we need is to be able to filter results to match the 'assigned to' to the currently logged in user. Any thoughts Magnity?
#7
+1
Any volunteer for a patch? I would be happy to contribute testing.
Attaching screenshot/mockup below to clarify expected result.
#8
Duplicate issues
#679702: See assigned tasks
#667150: Adding assigned person to task list and filter
#9
Hi,
is this already available in the dev Version. I did not get the time to check out the dev version yet, but maybe today i will get the time to have a look on it. If it is not already included i will make a patch soon.
Greetings
Carsten
#10
No this is not in the dev version. Someone must write a patch. Any volunteer?
#11
Hi,
will be available soon. It is on my list for today. If there are no disturbs you will get it today or within the next days.
#12
Hi,
here is the patch for the assigned to filter on the project, task and tickets page. Please test if it working correctly. I have already tested it in my on page but there is no warranty that is working 100%.
Just apply the patch to the storm folder. The follwing files should be patched:
Greetings
Carsten
#13
I've read through the code with dreditor and all seems fine.
Please could someone apply and test that it works as expected, and then it can be committed.
Patch status:
- Testbot: OK
- Code read through: OK
- Functional test: Pending
#14
Cool! Thank you for this. It does exactly what i was looking for and so far i've found no issues after applying the patch. Having said that, i've not given it extensive testing but it does at least seem to identify the users and teams correctly, passing those through to the filters as requested.
One result of this new work, is a new request which might be very simple to implement. Given that you've also got a '-mine-' filter in the drop down box, would it be possible to construct a URL that would take the user to "My Tasks" without needing to complete the form ? I'm thinking something like :
http://www.mydomain.com/storm/tasks?assigned_to=1&status=open
I notice the session stores the filter settings but the direct link could then make sure that whatever the 'last' filter was, the link took you directly to the setup for 'my tasks'.
#15
Hi af199,
this is already in construction in a contributed module on which i am working named storm_contrib. The dev Version will be released soon. There will be a callback URL for "My-Tasks" and "My Tickets". I do not want to add more functionallity to storm core by now because there are a lot of issues and there are companies already working with it. So new functionality maybe makes storm core unstable. So please be a little patient, the new module will be published as dev version soon (maybe this week)
Greetings
Carsten
#16
Hi Carsten, thanks for the reply. I can understand not wanting to make the core unstable and good to hear there is something on the horrizon for the menu links. I'm happy to be patient for that!
Does the project you mention exist already ? I can't seem to find it to watch for its updates.
Thanks, Andy Feltham.
#17
Hi all,
Just to add to those last couple of comments - all changes to Storm now go through automated testing, and hence I am asking for every code change to have a patch on a drupal.org issue.
If we want Storm to:
a) Become more reliable
b) Stay more reliable
Then we really need everyone to partake in two things:
a) Reviewing of patches, even if you're not directly interested in that issue - simply test that everything else works fine and nothing has been broken.
b) Writing tests.
A patch is merely a file which allows a machine to see changes made. If you haven't used them before - they are really simple, and probably more simple than you think. There are good guides at http://drupal.org/project/storm/cvs-instructions, http://drupal.org/patch/create and http://drupal.org/patch/apply.
Also, (well done if you have read this far), I've started a list where people can sign up to do particular things which will help Storm - this is at http://groups.drupal.org/node/54898. I hope it is pretty informal, but means that we can see that there are people who have committed to helping in various ways.
I really think that Storm can develop an order of magnitude faster if we all chip in and help each other out.
Hopefully with that in place, we wouldn't need to put new features in storm_contrib or anything like that - we'd be more sure that everything works together in Storm as a whole.
Thanks for listening!...
#18
If you're on Windows and want to contribute patch I wrote an how-to handbook at http://drupal.org/node/765120
If you're on Linux (Ubuntu) the how-to can be found at http://drupal.org/node/765124
This is the easiest way that I know of for creating patch. Once Eclipse is setup. You can very easily create a patch with a simple right click :) I'm not a coder and create patches with this tool ;)
Both how-tos are for absolute beginners.
#19
Hi juliangb,
you are right with #17. The aim is to make storm more reliable and better. My company wants to use it in the future and there are many other who are already working with it. We need some real new features like calculation of costs, considering of holidays and much more. That is too much stuff for the storm core to put it in patches. I made several submodules which will be available with storm_contrib and can be activated separatly. I agree that the aim is to push storm. So the plan is to publish storm_contrib (within the next days) and then to test it. If everything works fine we can move some of the submodules from storm_contrib to storm core.
But you also have to care about all the people who are already working with storm. If there are bugs in the new releases of storm nobody will be amused, especially if you are using it in a company or your total projects planning disappears. There will be also some problems if you are adding lots of features at once. So lets introduce new features once by once and let the user decide which features he needs.
So let us improve storm by reducing the issue queue of storm core and adding new features separately in new modules. If everything is working stable we can think about a 6.x.2 release including new features. But we have to care that the storm core does not get too heavy. Many people only need some basic features.
I think this is the best way and it is already used by many other modules and also for the Drupal core. I am afraid to anger all the users who are already using storm and all the people who just want the basic features and not a heavy module with much overkill. Maybe you agree with me.
So I am going back to work and try to improve storm ;-)
Greetings
Carsten
#20
+1 for sub-modules. I agree with Carsten. Several sub-modules is the Drupal way. The main advantages are
Two examples of already existing sub-modules
http://drupal.org/project/storm_dashboard
http://drupal.org/project/storm_quicktt
#21
Confirming that patch in #12 works. Thanks Carsten :)
I tested with the following.
*6.x-1.x-dev (2010-Apr-16)
*storm/tasks
*storm/tickets
*storm/projects
*update.php
#22
If someone else want to test attached is the full dev module with patch in #12 already applied. For test server only. Do not use on production server.
#23
Re the discussion on sub modules etc., (probably getting a little OT), I would actually be in favour of a different method of splitting up - actually taking an axe to various bits of Storm and using the functionality of other modules, and having Storm just providing the glue to make them work together out of the box a bit more. Anyway - if we want to continue this conversation, I suggest we open a thread at http://groups.drupal.org/storm.
I will commit the patch from #12 when I next have a connection that I can use CVS on.
The next step for this issue will be to get the assigned to filters working for the views integration.
#24
Hi,
the assigned to fields are already in the views. There are the following fields available:
Filters:
There is just a little bug in the ticket views integration. Here is the patch to fix it (just a k missing in stormticket)
Just apply the patch to the stormticket module.
When everything is tested i think we can close this issue.
#25
The last submitted patch, stormticket.views_.inc_assigned_nid.patch, failed testing.
#26
changed patch to be applied to storm module, not to submodule
#27
Committed #12 and #26.
Thanks all esp Carsten Muller for the patches.
#28
Automatically closed -- issue fixed for 2 weeks with no activity.