modules which fails an install requirement are enabled/installed anyway

Reviewing my patch, I noticed that I was affecting a variable which was also later used in the same function.

Attached is a fix with a slightly different approach which doesn't alter that variable.

I don't mind adding a log to the patch, but there's going to be a log already below in the function. Because the module that was skipped is part of the $modules array (the ones that were requested to be enabled), the following snippet (part of the current code) will found that one of the requested modules' status is still 0 (disabled) and then log the proper error about the module cannot being enabled.

    foreach ($modules as $module_name) {
      if ($enable) { 
        if ($module_info[$module_name]->status) {
          drush_log(dt('!module was enabled successfully.', array('!module' => $module_info[$module_name]->info['name'])), 'ok');
        }
        else {
          drush_set_error('DRUSH_PM_ENABLE_MODULE_ISSUE', dt('> There was a problem enabling !module.', array('!module' => $module_name)));
        }
      }
      else { 
        if (!$module_info[$module_name]->status) {
          drush_log(dt('!module was disabled successfully.', array('!module' => $module_info[$module_name]->info['name'])), 'ok');
        }
        else {
          drush_set_error('DRUSH_PM_DISABLE_MODULE_ISSUE', dt('> There was a problem disabling !module.', array('!module' => $module_name)));
        }
      }
    }

And worth noting that the failed requirement it's likely to set a proper error message as well.

Bumping up this issue, any work or review needed from me?

Bumping this issue up once more. If these bumps up bother please let me know and I stop. I just go over my issues from time to time and bump up the ones that I feel worth some attention.

done :)!